All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: kvm@vger.kernel.org
Cc: dzickus@redhat.com, pbonzini@redhat.com, gleb@redhat.com,
	linux-kernel@vger.kernel.org,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: [patch 2/2] hung_task: add method to reset detector
Date: Fri, 11 Oct 2013 21:39:26 -0300	[thread overview]
Message-ID: <20131012004217.058840904@amt.cnet> (raw)
In-Reply-To: 20131012003924.092908362@amt.cnet

[-- Attachment #1: 01-hung-task-watchdog-reset --]
[-- Type: text/plain, Size: 1949 bytes --]

In certain occasions it is possible for a hung task detector
positive to be false: continuation from a paused VM, for example.

Add a method to reset detection, similar as is done
with other kernel watchdogs.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: kvm/kernel/hung_task.c
===================================================================
--- kvm.orig/kernel/hung_task.c
+++ kvm/kernel/hung_task.c
@@ -203,6 +203,14 @@ int proc_dohung_task_timeout_secs(struct
 	return ret;
 }
 
+static atomic_t reset_hung_task = ATOMIC_INIT(0);
+
+void reset_hung_task_detector(void)
+{
+	atomic_set(&reset_hung_task, 1);
+}
+EXPORT_SYMBOL_GPL(reset_hung_task_detector);
+
 /*
  * kthread which checks for tasks stuck in D state
  */
@@ -216,6 +224,9 @@ static int watchdog(void *dummy)
 		while (schedule_timeout_interruptible(timeout_jiffies(timeout)))
 			timeout = sysctl_hung_task_timeout_secs;
 
+		if (atomic_xchg(&reset_hung_task, 0))
+			continue;
+
 		check_hung_uninterruptible_tasks(timeout);
 	}
 
Index: kvm/include/linux/sched.h
===================================================================
--- kvm.orig/include/linux/sched.h
+++ kvm/include/linux/sched.h
@@ -285,6 +285,14 @@ static inline void lockup_detector_init(
 }
 #endif
 
+#ifdef CONFIG_DETECT_HUNG_TASK
+void reset_hung_task_detector(void);
+#else
+static inline void reset_hung_task_detector(void)
+{
+}
+#endif
+
 /* Attach to any functions which should be ignored in wchan output. */
 #define __sched		__attribute__((__section__(".sched.text")))
 
Index: kvm/arch/x86/kernel/pvclock.c
===================================================================
--- kvm.orig/arch/x86/kernel/pvclock.c
+++ kvm/arch/x86/kernel/pvclock.c
@@ -48,6 +48,7 @@ void pvclock_touch_watchdogs(void)
 	touch_softlockup_watchdog_sync();
 	clocksource_touch_watchdog();
 	rcu_cpu_stall_reset();
+	reset_hung_task_detector();
 }
 
 static atomic64_t last_value = ATOMIC64_INIT(0);

  parent reply	other threads:[~2013-10-12  0:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08  1:05 [patch 0/3] generic kernel watchdog reset at pvclock read Marcelo Tosatti
2013-10-08  1:05 ` [patch 1/3] hung_task: add method to reset detector Marcelo Tosatti
2013-10-08 13:35   ` Don Zickus
2013-10-08  1:05 ` [patch 2/3] pvclock: detect watchdog reset at pvclock read Marcelo Tosatti
2013-10-08  9:58   ` Paolo Bonzini
2013-10-09  1:22     ` Marcelo Tosatti
2013-10-09  8:39       ` Paolo Bonzini
2013-10-08 13:37   ` Don Zickus
2013-10-08 22:08     ` Marcelo Tosatti
2013-10-09 13:55       ` Don Zickus
2013-10-09 21:26         ` Marcelo Tosatti
2013-10-16 18:22           ` Don Zickus
2013-10-08  1:05 ` [patch 3/3] 01-hung-task-watchdog-reset 02-kvmclock-touch-watchdog-on-kvmclock-read series Marcelo Tosatti
2013-10-08  1:07   ` Marcelo Tosatti
2013-10-08  9:57 ` [patch 0/3] generic kernel watchdog reset at pvclock read Paolo Bonzini
2013-10-12  0:39 ` [patch 0/2] generic kernel watchdog reset at pvclock read (v2) Marcelo Tosatti
2013-10-12  0:39   ` [patch 1/2] pvclock: detect watchdog reset at pvclock read Marcelo Tosatti
2013-10-12  0:39   ` Marcelo Tosatti [this message]
2013-10-14 11:30   ` [patch 0/2] generic kernel watchdog reset at pvclock read (v2) Paolo Bonzini
2013-10-16 18:25   ` Don Zickus
2013-10-16 21:02     ` Marcelo Tosatti
2013-11-06  7:49   ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131012004217.058840904@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.