From: Shaohua Li <shli@kernel.org>
To: Kent Overstreet <kmo@daterainc.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk
Subject: Re: [patch 1/4] percpu_ida: make percpu_ida percpu size/batch configurable
Date: Sat, 12 Oct 2013 08:52:27 +0800 [thread overview]
Message-ID: <20131012005227.GB17666@kernel.org> (raw)
In-Reply-To: <20131011203152.GH28572@kmo>
On Fri, Oct 11, 2013 at 01:31:52PM -0700, Kent Overstreet wrote:
> On Fri, Oct 11, 2013 at 03:18:03PM +0800, Shaohua Li wrote:
> > Make percpu_ida percpu size/batch configurable. The block-mq-tag will use it.
>
> Can you explain the justification for this? Performance...?
The performance using percpu_ida for tag management? Please see the patch 4
thread. If you ask the justification of making the size/batch configurable,
the answer is we might have no enough tags, and default cache size/batch is too
aggressive.
Thanks,
Shaohua
next prev parent reply other threads:[~2013-10-12 0:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 7:18 [patch 0/4] blk-mq: use percpu_ida to manage tags Shaohua Li
2013-10-11 7:18 ` [patch 1/4] percpu_ida: make percpu_ida percpu size/batch configurable Shaohua Li
2013-10-11 20:31 ` Kent Overstreet
2013-10-12 0:52 ` Shaohua Li [this message]
2013-10-11 7:18 ` [patch 2/4] percpu_ida: add percpu_ida_for_each_free Shaohua Li
2013-10-11 20:34 ` Kent Overstreet
2013-10-11 7:18 ` [patch 3/4] percpu_ida: add an API to return free tags Shaohua Li
2013-10-11 20:35 ` Kent Overstreet
2013-10-12 1:02 ` Shaohua Li
2013-10-11 7:18 ` [patch 4/4] blk-mq: switch to percpu-ida for tag menagement Shaohua Li
2013-10-11 14:28 ` Jens Axboe
2013-10-12 0:49 ` Shaohua Li
2013-10-13 18:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012005227.GB17666@kernel.org \
--to=shli@kernel.org \
--cc=axboe@kernel.dk \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.