From: Greg KH <gregkh@linuxfoundation.org>
To: Ethan Zhao <ethan.kernel@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/base/core.c: always output device renaming messages.
Date: Sat, 12 Oct 2013 10:50:34 -0700 [thread overview]
Message-ID: <20131012175034.GA3858@kroah.com> (raw)
In-Reply-To: <CABawtvP+BqpwGYJpvBVbEUyqptSWoF0YEGqbT6o+aTP2326+7A@mail.gmail.com>
On Sat, Oct 12, 2013 at 02:52:51PM +0800, Ethan Zhao wrote:
> >> --- a/drivers/base/core.c
> >> +++ b/drivers/base/core.c
> >> @@ -1904,8 +1904,7 @@ int device_rename(struct device *dev, const char *new_name)
> >> if (!dev)
> >> return -EINVAL;
> >>
> >> - pr_debug("device: '%s': %s: renaming to '%s'\n", dev_name(dev),
> >> - __func__, new_name);
> >> + dev_info(dev, "'%s' renaming to '%s'\n", dev_name(dev), new_name);
> >
> > How about:
> > dev_dbg(dev, "renaming to '%s'\n", new_name);
>
> If something confusing or wrong, need to take a look.
> For pr_debug(), We have to build and load a debug kernel…
> For dev_dbg(), We have to rebuild a kernel with CONFIG_DYNAMIC_DEBUG
> set to 'y', that is default 'n'.
Why would you not enable that option these days? All distros enable it,
and if you should too :)
> So, do you mean
>
> dev_printk(KERN_DEBUG, dev, "renaming to '%s'\n", new_name); ?
No, dev_dbg();.
thanks,
greg k-h
next prev parent reply other threads:[~2013-10-12 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1381460298-1097-1-git-send-email-ethan.kernel@gmail.com>
2013-10-11 15:35 ` [PATCH] drivers/base/core.c: always output device renaming messages Greg KH
2013-10-11 16:08 ` Bjorn Helgaas
2013-10-11 16:12 ` Greg KH
[not found] ` <F6FB0E698C9B3143BDF729DF222866466FD67CA7@ORSMSX110.amr.corp.intel.com>
2013-10-12 6:55 ` Ethan Zhao
2013-10-12 7:11 ` [PATCH] ixgbevf: Fix the debugging output when device is not registered Joe Perches
2013-10-12 7:03 ` [PATCH] drivers/base/core.c: always output device renaming messages Ethan Zhao
2013-10-12 6:52 ` Ethan Zhao
2013-10-12 17:50 ` Greg KH [this message]
2013-10-13 1:34 ` Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131012175034.GA3858@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ethan.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.