From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Date: Sun, 13 Oct 2013 09:31:29 +0000 Subject: Re: [PATCH 0/6] Get rid of mandatory huge page defines Message-Id: <20131013093129.GF15657@redhat.com> List-Id: References: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> In-Reply-To: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On Sat, Oct 12, 2013 at 10:36:36AM -0700, Christoffer Dall wrote: > On Wed, Oct 02, 2013 at 02:22:27PM -0700, Christoffer Dall wrote: > > The current KVM code relies on a number of definitions to exist for each > > architecture: > > KVM_HPAGE_GFN_SHIFT > > KVM_NR_HPAGE_SIZES > > KVM_PAGES_PER_HPAGE > > > > However, these defines are only used in the gfn_to_index function, which > > is only used in the x86 code. This series moves the gfn_to_index > > function from the generic KVM code into the x86 world and gets rid of > > the definitions from archiectures that don't use them. s390 actually > > uses these values in other code, so we leave that part untouched. > > > > Patches based on kvm/next and available here: > > git://git.linaro.org/people/cdall/linux-kvm-arm.git kvm-pagesize-cleanup > > > > Christoffer Dall (6): > > KVM: Move gfn_to_index to x86 specific code > > KVM: ARM: Get rid of KVM_HPAGE defines > > KVM: arm64: Get rid of KVM_HPAGE defines > > KVM: mips: Get rid of KVM_HPAGE defines > > KVM: ia64: Get rid of KVM_HPAGE defines > > KVM: PPC: Get rid of KVM_HPAGE defines > > > > Any comments on this one? I'd very much like to merge huge page support > for KVM/ARM during the next merge window and it depends on this > series. > Looks fine to me, but why have you skipped s390? -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Date: Sun, 13 Oct 2013 09:31:29 +0000 Subject: Re: [PATCH 0/6] Get rid of mandatory huge page defines Message-Id: <20131013093129.GF15657@redhat.com> List-Id: References: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> <20131012173636.GL5108@cbox> In-Reply-To: <20131012173636.GL5108@cbox> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoffer Dall Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, Paolo Bonzini , Marc Zyngier On Sat, Oct 12, 2013 at 10:36:36AM -0700, Christoffer Dall wrote: > On Wed, Oct 02, 2013 at 02:22:27PM -0700, Christoffer Dall wrote: > > The current KVM code relies on a number of definitions to exist for each > > architecture: > > KVM_HPAGE_GFN_SHIFT > > KVM_NR_HPAGE_SIZES > > KVM_PAGES_PER_HPAGE > > > > However, these defines are only used in the gfn_to_index function, which > > is only used in the x86 code. This series moves the gfn_to_index > > function from the generic KVM code into the x86 world and gets rid of > > the definitions from archiectures that don't use them. s390 actually > > uses these values in other code, so we leave that part untouched. > > > > Patches based on kvm/next and available here: > > git://git.linaro.org/people/cdall/linux-kvm-arm.git kvm-pagesize-cleanup > > > > Christoffer Dall (6): > > KVM: Move gfn_to_index to x86 specific code > > KVM: ARM: Get rid of KVM_HPAGE defines > > KVM: arm64: Get rid of KVM_HPAGE defines > > KVM: mips: Get rid of KVM_HPAGE defines > > KVM: ia64: Get rid of KVM_HPAGE defines > > KVM: PPC: Get rid of KVM_HPAGE defines > > > > Any comments on this one? I'd very much like to merge huge page support > for KVM/ARM during the next merge window and it depends on this > series. > Looks fine to me, but why have you skipped s390? -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 0/6] Get rid of mandatory huge page defines Date: Sun, 13 Oct 2013 12:31:29 +0300 Message-ID: <20131013093129.GF15657@redhat.com> References: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> <20131012173636.GL5108@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, Paolo Bonzini , Marc Zyngier To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42133 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753841Ab3JMJbp (ORCPT ); Sun, 13 Oct 2013 05:31:45 -0400 Content-Disposition: inline In-Reply-To: <20131012173636.GL5108@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Oct 12, 2013 at 10:36:36AM -0700, Christoffer Dall wrote: > On Wed, Oct 02, 2013 at 02:22:27PM -0700, Christoffer Dall wrote: > > The current KVM code relies on a number of definitions to exist for each > > architecture: > > KVM_HPAGE_GFN_SHIFT > > KVM_NR_HPAGE_SIZES > > KVM_PAGES_PER_HPAGE > > > > However, these defines are only used in the gfn_to_index function, which > > is only used in the x86 code. This series moves the gfn_to_index > > function from the generic KVM code into the x86 world and gets rid of > > the definitions from archiectures that don't use them. s390 actually > > uses these values in other code, so we leave that part untouched. > > > > Patches based on kvm/next and available here: > > git://git.linaro.org/people/cdall/linux-kvm-arm.git kvm-pagesize-cleanup > > > > Christoffer Dall (6): > > KVM: Move gfn_to_index to x86 specific code > > KVM: ARM: Get rid of KVM_HPAGE defines > > KVM: arm64: Get rid of KVM_HPAGE defines > > KVM: mips: Get rid of KVM_HPAGE defines > > KVM: ia64: Get rid of KVM_HPAGE defines > > KVM: PPC: Get rid of KVM_HPAGE defines > > > > Any comments on this one? I'd very much like to merge huge page support > for KVM/ARM during the next merge window and it depends on this > series. > Looks fine to me, but why have you skipped s390? -- Gleb.