From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Date: Mon, 14 Oct 2013 07:20:40 +0000 Subject: Re: [PATCH 0/6] Get rid of mandatory huge page defines Message-Id: <20131014072040.GK15657@redhat.com> List-Id: References: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> In-Reply-To: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On Sun, Oct 13, 2013 at 08:29:43PM +0100, Christoffer Dall wrote: > On Sun, Oct 13, 2013 at 08:49:28PM +0300, Gleb Natapov wrote: > > On Sun, Oct 13, 2013 at 06:41:22PM +0100, Christoffer Dall wrote: > > > On Sun, Oct 13, 2013 at 12:31:29PM +0300, Gleb Natapov wrote: > > > > On Sat, Oct 12, 2013 at 10:36:36AM -0700, Christoffer Dall wrote: > > > > > On Wed, Oct 02, 2013 at 02:22:27PM -0700, Christoffer Dall wrote: > > > > > > The current KVM code relies on a number of definitions to exist for each > > > > > > architecture: > > > > > > KVM_HPAGE_GFN_SHIFT > > > > > > KVM_NR_HPAGE_SIZES > > > > > > KVM_PAGES_PER_HPAGE > > > > > > > > > > > > However, these defines are only used in the gfn_to_index function, which > > > > > > is only used in the x86 code. This series moves the gfn_to_index > > > > > > function from the generic KVM code into the x86 world and gets rid of > > > > > > the definitions from archiectures that don't use them. s390 actually > > > > > > uses these values in other code, so we leave that part untouched. > > > > > > > > > > > > Patches based on kvm/next and available here: > > > > > > git://git.linaro.org/people/cdall/linux-kvm-arm.git kvm-pagesize-cleanup > > > > > > > > > > > > Christoffer Dall (6): > > > > > > KVM: Move gfn_to_index to x86 specific code > > > > > > KVM: ARM: Get rid of KVM_HPAGE defines > > > > > > KVM: arm64: Get rid of KVM_HPAGE defines > > > > > > KVM: mips: Get rid of KVM_HPAGE defines > > > > > > KVM: ia64: Get rid of KVM_HPAGE defines > > > > > > KVM: PPC: Get rid of KVM_HPAGE defines > > > > > > > > > > > > > > > > Any comments on this one? I'd very much like to merge huge page support > > > > > for KVM/ARM during the next merge window and it depends on this > > > > > series. > > > > > > > > > Looks fine to me, but why have you skipped s390? > > > > > > > > > > Because the defines are actually used in their code, see above: > > > > > > "... s390 actually uses these values in other code, so we leave that > > > part untouched." > > > > > It does? Where? I actually removed then and the code still build. > > > > Eh, I can't find them either. I must have messed something up, sorry > about that. Missing patch following! > Thanks, applied all to queue. > > > Will you apply these from the mailing list or should I send you a pull > > > request? > > > > > I will apply them from the mailing list. > > > > Thanks! > > -Christoffer -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Date: Mon, 14 Oct 2013 07:20:40 +0000 Subject: Re: [PATCH 0/6] Get rid of mandatory huge page defines Message-Id: <20131014072040.GK15657@redhat.com> List-Id: References: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> <20131012173636.GL5108@cbox> <20131013093129.GF15657@redhat.com> <20131013174122.GA53064@lvm> <20131013174928.GE14789@redhat.com> <20131013192943.GB53064@lvm> In-Reply-To: <20131013192943.GB53064@lvm> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoffer Dall Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, Paolo Bonzini , Marc Zyngier On Sun, Oct 13, 2013 at 08:29:43PM +0100, Christoffer Dall wrote: > On Sun, Oct 13, 2013 at 08:49:28PM +0300, Gleb Natapov wrote: > > On Sun, Oct 13, 2013 at 06:41:22PM +0100, Christoffer Dall wrote: > > > On Sun, Oct 13, 2013 at 12:31:29PM +0300, Gleb Natapov wrote: > > > > On Sat, Oct 12, 2013 at 10:36:36AM -0700, Christoffer Dall wrote: > > > > > On Wed, Oct 02, 2013 at 02:22:27PM -0700, Christoffer Dall wrote: > > > > > > The current KVM code relies on a number of definitions to exist for each > > > > > > architecture: > > > > > > KVM_HPAGE_GFN_SHIFT > > > > > > KVM_NR_HPAGE_SIZES > > > > > > KVM_PAGES_PER_HPAGE > > > > > > > > > > > > However, these defines are only used in the gfn_to_index function, which > > > > > > is only used in the x86 code. This series moves the gfn_to_index > > > > > > function from the generic KVM code into the x86 world and gets rid of > > > > > > the definitions from archiectures that don't use them. s390 actually > > > > > > uses these values in other code, so we leave that part untouched. > > > > > > > > > > > > Patches based on kvm/next and available here: > > > > > > git://git.linaro.org/people/cdall/linux-kvm-arm.git kvm-pagesize-cleanup > > > > > > > > > > > > Christoffer Dall (6): > > > > > > KVM: Move gfn_to_index to x86 specific code > > > > > > KVM: ARM: Get rid of KVM_HPAGE defines > > > > > > KVM: arm64: Get rid of KVM_HPAGE defines > > > > > > KVM: mips: Get rid of KVM_HPAGE defines > > > > > > KVM: ia64: Get rid of KVM_HPAGE defines > > > > > > KVM: PPC: Get rid of KVM_HPAGE defines > > > > > > > > > > > > > > > > Any comments on this one? I'd very much like to merge huge page support > > > > > for KVM/ARM during the next merge window and it depends on this > > > > > series. > > > > > > > > > Looks fine to me, but why have you skipped s390? > > > > > > > > > > Because the defines are actually used in their code, see above: > > > > > > "... s390 actually uses these values in other code, so we leave that > > > part untouched." > > > > > It does? Where? I actually removed then and the code still build. > > > > Eh, I can't find them either. I must have messed something up, sorry > about that. Missing patch following! > Thanks, applied all to queue. > > > Will you apply these from the mailing list or should I send you a pull > > > request? > > > > > I will apply them from the mailing list. > > > > Thanks! > > -Christoffer -- Gleb. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 0/6] Get rid of mandatory huge page defines Date: Mon, 14 Oct 2013 10:20:40 +0300 Message-ID: <20131014072040.GK15657@redhat.com> References: <1380748953-7864-1-git-send-email-christoffer.dall@linaro.org> <20131012173636.GL5108@cbox> <20131013093129.GF15657@redhat.com> <20131013174122.GA53064@lvm> <20131013174928.GE14789@redhat.com> <20131013192943.GB53064@lvm> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, Paolo Bonzini , Marc Zyngier To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37540 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259Ab3JNHVF (ORCPT ); Mon, 14 Oct 2013 03:21:05 -0400 Content-Disposition: inline In-Reply-To: <20131013192943.GB53064@lvm> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Oct 13, 2013 at 08:29:43PM +0100, Christoffer Dall wrote: > On Sun, Oct 13, 2013 at 08:49:28PM +0300, Gleb Natapov wrote: > > On Sun, Oct 13, 2013 at 06:41:22PM +0100, Christoffer Dall wrote: > > > On Sun, Oct 13, 2013 at 12:31:29PM +0300, Gleb Natapov wrote: > > > > On Sat, Oct 12, 2013 at 10:36:36AM -0700, Christoffer Dall wrote: > > > > > On Wed, Oct 02, 2013 at 02:22:27PM -0700, Christoffer Dall wrote: > > > > > > The current KVM code relies on a number of definitions to exist for each > > > > > > architecture: > > > > > > KVM_HPAGE_GFN_SHIFT > > > > > > KVM_NR_HPAGE_SIZES > > > > > > KVM_PAGES_PER_HPAGE > > > > > > > > > > > > However, these defines are only used in the gfn_to_index function, which > > > > > > is only used in the x86 code. This series moves the gfn_to_index > > > > > > function from the generic KVM code into the x86 world and gets rid of > > > > > > the definitions from archiectures that don't use them. s390 actually > > > > > > uses these values in other code, so we leave that part untouched. > > > > > > > > > > > > Patches based on kvm/next and available here: > > > > > > git://git.linaro.org/people/cdall/linux-kvm-arm.git kvm-pagesize-cleanup > > > > > > > > > > > > Christoffer Dall (6): > > > > > > KVM: Move gfn_to_index to x86 specific code > > > > > > KVM: ARM: Get rid of KVM_HPAGE defines > > > > > > KVM: arm64: Get rid of KVM_HPAGE defines > > > > > > KVM: mips: Get rid of KVM_HPAGE defines > > > > > > KVM: ia64: Get rid of KVM_HPAGE defines > > > > > > KVM: PPC: Get rid of KVM_HPAGE defines > > > > > > > > > > > > > > > > Any comments on this one? I'd very much like to merge huge page support > > > > > for KVM/ARM during the next merge window and it depends on this > > > > > series. > > > > > > > > > Looks fine to me, but why have you skipped s390? > > > > > > > > > > Because the defines are actually used in their code, see above: > > > > > > "... s390 actually uses these values in other code, so we leave that > > > part untouched." > > > > > It does? Where? I actually removed then and the code still build. > > > > Eh, I can't find them either. I must have messed something up, sorry > about that. Missing patch following! > Thanks, applied all to queue. > > > Will you apply these from the mailing list or should I send you a pull > > > request? > > > > > I will apply them from the mailing list. > > > > Thanks! > > -Christoffer -- Gleb.