From: Johannes Thumshirn <johannes.thumshirn@men.de>
To: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Cc: <dougthompson@xmission.com>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC: remove deprecated IRQF_DISABLED
Date: Mon, 14 Oct 2013 11:56:02 +0200 [thread overview]
Message-ID: <20131014095602.GA14274@jtlinux> (raw)
In-Reply-To: <1381641477-7373-1-git-send-email-michael.opdenacker@free-electrons.com>
On Sun, Oct 13, 2013 at 07:17:57AM +0200, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
> drivers/edac/mpc85xx_edac.c | 7 +++----
> drivers/edac/mv64x60_edac.c | 8 ++++----
> drivers/edac/ppc4xx_edac.c | 4 ++--
> 3 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 3eb32f6..7785807 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -297,7 +297,7 @@ int mpc85xx_pci_err_probe(struct platform_device *op)
> if (edac_op_state == EDAC_OPSTATE_INT) {
> pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
> res = devm_request_irq(&op->dev, pdata->irq,
> - mpc85xx_pci_isr, IRQF_DISABLED,
> + mpc85xx_pci_isr, 0,
> "[EDAC] PCI err", pci);
> if (res < 0) {
> printk(KERN_ERR
> @@ -579,7 +579,7 @@ static int mpc85xx_l2_err_probe(struct platform_device *op)
> if (edac_op_state == EDAC_OPSTATE_INT) {
> pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
> res = devm_request_irq(&op->dev, pdata->irq,
> - mpc85xx_l2_isr, IRQF_DISABLED,
> + mpc85xx_l2_isr, 0,
> "[EDAC] L2 err", edac_dev);
> if (res < 0) {
> printk(KERN_ERR
> @@ -1078,8 +1078,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
> /* register interrupts */
> pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
> res = devm_request_irq(&op->dev, pdata->irq,
> - mpc85xx_mc_isr,
> - IRQF_DISABLED | IRQF_SHARED,
> + mpc85xx_mc_isr, IRQF_SHARED,
> "[EDAC] MC err", mci);
> if (res < 0) {
> printk(KERN_ERR "%s: Unable to request irq %d for "
Hi Michael,
mpc85xx_edac has them already removed in the version that is going into 3.13.
Sorry for the inconvenience. I'll set up a public tree at my github repo, so
everyone can see the current mpc85xx_edac state.
Byte,
Johannes
next prev parent reply other threads:[~2013-10-14 9:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 5:17 [PATCH] EDAC: remove deprecated IRQF_DISABLED Michael Opdenacker
2013-10-14 9:56 ` Johannes Thumshirn [this message]
2013-10-14 11:14 ` Michael Opdenacker
2014-03-05 5:04 ` Michael Opdenacker
2014-03-05 6:49 ` Borislav Petkov
2014-03-08 5:15 ` Michael Opdenacker
2014-03-17 7:42 ` Johannes Thumshirn
2014-10-01 10:18 ` Michael Opdenacker
2014-10-01 10:24 ` Michael Opdenacker
2014-10-01 18:42 ` Borislav Petkov
2014-10-01 10:27 ` Borislav Petkov
2014-10-01 20:17 ` Michael Opdenacker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014095602.GA14274@jtlinux \
--to=johannes.thumshirn@men.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.