Re: [nftables-kernel PATCH 0/7] API minor fixes and improvement proposals

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Mon, Oct 14, 2013 at 03:46:49PM +0300, Tomasz Bursztyka wrote:
> Hi, 
> 
> First 2 minor fixes:
> -------------------
> 
> patch 1: don't know why I messed up here in my previous documentation patch, my mistake anyway.
> patch 2: an old left-over. Why has priv->len been corrupted before?

Will pick these two.

> And 5 proposals:
> ---------------
> 
> patch 3: Let's expose table's usage (so user might decide if it's worth dumping table's content, it can useful info finally)

Call it _USE.

> patch 4: That one is debatable: NFTA_CHAIN_USE is - imho - not enough self-explanatory.
> NFTA_CHAIN_REFS (or NFTA_CHAIN_REFERENCES?) is much better. If there is a time to change such minor details, it's now or never.

We're using _USE in other parts of the netfilter code, that can be
document, really I don't think it's worth to discuss this renaming
thing.

> patch 5: add a meta key to get dev->addr_len
> 
> patch 6: add lshift/rshift to bitwise expression. It's a first shot, which should work pretty well already. Maybe there are improvments which could be done, depending on data length (2 or 4: we could cast to u64 thus reducing shifts by 2).
> 	At least I tried to keep the API sane, and c/p the byteorder way. sreg, dreg, op, len, mask are mandatory. xor and shift are related to the selected op.
> 
> patch 7: patch's commit message says all.

Code for user-space is missing, won't take these until finished.