From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
Bert DeKnuydt <Bert.Deknuydt@esat.kuleuven.be>
Subject: Re: [PATCH] tune2fs: more respect for quota config option
Date: Mon, 14 Oct 2013 09:03:50 -0400 [thread overview]
Message-ID: <20131014130350.GH9609@thunk.org> (raw)
In-Reply-To: <52420014.8090901@redhat.com>
On Tue, Sep 24, 2013 at 04:11:48PM -0500, Eric Sandeen wrote:
> Commit 44a2cca3 disabled tune2fs -O quota when the build
> didn't have --enable-quota at configure time, but that
> wasn't quite enough.
>
> We need to exclude the "-Q" option as well from tune2fs
> when --enable-quota isn't specified at configure time.
>
> Otherwise, tune2fs -Q can set the quota feature, but no other
> utility will touch the filesystem due to the unknown flag,
> if buitl w/o --enable-quota.
>
> So put everything related to "-Q" under #ifdef CONFIG_QUOTA;
> usage output (was missing before) and option parsing.
>
> Addresses-Red-Hat-Bugzilla: #1010709
> Reported-by: Bert DeKnuydt <Bert.Deknuydt@esat.kuleuven.be>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied to maint branch, thanks.
- Ted
prev parent reply other threads:[~2013-10-14 13:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 21:11 [PATCH] tune2fs: more respect for quota config option Eric Sandeen
2013-10-14 13:03 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014130350.GH9609@thunk.org \
--to=tytso@mit.edu \
--cc=Bert.Deknuydt@esat.kuleuven.be \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.