From: Theodore Ts'o <tytso@mit.edu>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: linux-ext4@vger.kernel.org, dvhart@linux.intel.com
Subject: Re: [RFC 10/10] debugfs: use the functions in misc/util.c
Date: Mon, 14 Oct 2013 10:40:12 -0400 [thread overview]
Message-ID: <20131014144012.GA26576@thunk.org> (raw)
In-Reply-To: <1377667560-20089-11-git-send-email-liezhi.yang@windriver.com>
On Wed, Aug 28, 2013 at 01:26:00PM +0800, Robert Yang wrote:
> Use the functions in mist/util.c to reduce the duplicated code.
This patch conflicts with an earlier patch you had sent which allowed
copy_file() to handle sparse files.
Also, could you move all of the functions which you added to
misc/util.c to a new file, named something like misc/create_inode.c,
or something like that?
That will avoid bloating the tune2fs binary, which won't need any of
these new functions.
Eventually, I plan to rename libquota to libinternal, and use it for
internal functions used by e2fsprogs, and at that point we'll move
misc/util.c, e2fsck/profile.c, and the functions for creating inodes
into this libinternal library.
But for now, if you could organize these functions into a one or more
separate .c files, and leave them in the misc directory, that would be
great.
Thanks!!
- Ted
next prev parent reply other threads:[~2013-10-14 14:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 5:25 [RFC 00/10] e2fsprogs/mke2fs: add an option: -d root-directory Robert Yang
2013-08-28 5:25 ` [RFC 01/10] mke2fs.c: " Robert Yang
2013-10-14 2:41 ` Theodore Ts'o
2013-10-14 12:22 ` [PATCH] mke2fs: fix up the commit "mke2fs.c: add an option: -d root-directory" Theodore Ts'o
2013-10-14 16:26 ` [RFC 01/10] mke2fs.c: add an option: -d root-directory Darren Hart
2013-10-15 1:38 ` Robert Yang
2013-08-28 5:25 ` [RFC 02/10] misc/util.c: implement populate_fs() Robert Yang
2013-08-28 5:25 ` [RFC 03/10] misc/util.c: create special file Robert Yang
2013-08-28 5:25 ` [RFC 04/10] misc/util.c: create symlink Robert Yang
2013-08-28 5:25 ` [RFC 05/10] misc/util.c: copy regular file Robert Yang
2013-08-28 5:25 ` [RFC 06/10] misc/util.c: create directory Robert Yang
2013-08-28 5:25 ` [RFC 07/10] misc/util.c: set more information for inode Robert Yang
2013-08-28 5:25 ` [RFC 08/10] misc/util.c: handle hardlinks Robert Yang
2013-08-28 5:25 ` [RFC 09/10] mke2fs.8.in: update the manual for the -d option Robert Yang
2013-08-28 5:26 ` [RFC 10/10] debugfs: use the functions in misc/util.c Robert Yang
2013-10-14 14:40 ` Theodore Ts'o [this message]
2013-09-01 3:26 ` [RFC 00/10] e2fsprogs/mke2fs: add an option: -d root-directory Zheng Liu
2013-09-02 6:46 ` Robert Yang
2013-09-02 11:55 ` Zheng Liu
2013-09-02 12:20 ` Robert Yang
2013-09-02 12:27 ` Zheng Liu
2013-09-16 21:04 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014144012.GA26576@thunk.org \
--to=tytso@mit.edu \
--cc=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.