From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Anton Arapov <aarapov@redhat.com>,
David Smith <dsmith@redhat.com>,
"Frank Ch. Eigler" <fche@redhat.com>,
Martin Cermak <mcermak@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] uprobes: fix fork() with the pending ret-probe(s)
Date: Mon, 14 Oct 2013 20:29:03 +0200 [thread overview]
Message-ID: <20131014182903.GA14115@redhat.com> (raw)
In-Reply-To: <20131013191815.GA32466@redhat.com>
On 10/13, Oleg Nesterov wrote:
>
> Please review, this series fixes the serious bug reported by
> Martin and David and cc's stable. See the changelog in 5/5.
Forgot to mention...
This probably needs another patch to handle the special case, vfork().
In this case it would be more correct to dup return_instances but
(obviously) avoid dup_xol_area.
However I think this is not that important, the child should not "unwind"
the stack if it shares mm/stack with its parent, otherwise it can corrupt
the parent's stack.
So I think that this change (which needs to pass "clone_flags" to
uprobe_copy_process) is not the stable material. But I'll update the
changelog in 4/5 to explain that "mm == t->mm" check should be updated.
Oleg.
next prev parent reply other threads:[~2013-10-14 18:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 19:18 [PATCH 0/5] uprobes: fix fork() with the pending ret-probe(s) Oleg Nesterov
2013-10-13 19:18 ` [PATCH 1/5] uprobes: Change the callsite of uprobe_copy_process() Oleg Nesterov
2013-10-16 12:37 ` Srikar Dronamraju
2013-10-13 19:18 ` [PATCH 2/5] uprobes: Introduce __create_xol_area() Oleg Nesterov
2013-10-16 12:41 ` Srikar Dronamraju
2013-10-16 12:50 ` Srikar Dronamraju
2013-10-13 19:18 ` [PATCH 3/5] uprobes: Teach __create_xol_area() to accept the predefined vaddr Oleg Nesterov
2013-10-16 12:43 ` Srikar Dronamraju
2013-10-13 19:18 ` [PATCH 4/5] uprobes: Change uprobe_copy_process() to dup return_instances Oleg Nesterov
2013-10-14 18:45 ` Peter Zijlstra
2013-10-14 19:00 ` Oleg Nesterov
2013-10-16 12:47 ` Srikar Dronamraju
2013-10-13 19:18 ` [PATCH 5/5] uprobes: Change uprobe_copy_process() to dup xol_area Oleg Nesterov
2013-10-14 14:09 ` Peter Zijlstra
2013-10-14 14:55 ` Oleg Nesterov
2013-10-14 15:47 ` Peter Zijlstra
2013-10-16 12:53 ` Srikar Dronamraju
2013-10-16 16:09 ` Oleg Nesterov
2013-10-18 15:49 ` Oleg Nesterov
2013-10-14 18:29 ` Oleg Nesterov [this message]
2013-10-16 17:38 ` [PATCH 0/5] uprobes: fix fork() with the pending ret-probe(s) Oleg Nesterov
2013-10-16 17:39 ` [PATCH 6/5] uprobes: Teach uprobe_copy_process() to handle CLONE_VFORK Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014182903.GA14115@redhat.com \
--to=oleg@redhat.com \
--cc=aarapov@redhat.com \
--cc=dsmith@redhat.com \
--cc=fche@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcermak@redhat.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.