From: Tino Reichardt <list-linux-netdev@mcmilk.de>
To: netdev@vger.kernel.org
Subject: Re: [PATCH 01/07] 8139too: Support for byte queue limits
Date: Mon, 14 Oct 2013 21:52:01 +0200 [thread overview]
Message-ID: <20131014195201.GD23070@mcmilk.de> (raw)
In-Reply-To: <1381777891.2045.1.camel@edumazet-glaptop.roam.corp.google.com>
* Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Mon, 2013-10-14 at 20:26 +0200, Tino Reichardt wrote:
> > Changes to 8139too to use byte queue limits.
> >
> > @@ -1733,6 +1735,7 @@ static netdev_tx_t rtl8139_start_xmit (struct sk_buff *skb,
> > tp->tx_flag | max(len, (unsigned int)ETH_ZLEN));
> >
> > tp->cur_tx++;
> > + netdev_sent_queue(dev, len);
> >
>
> This looks wrong if len < ETH_ZLEN
Fixed this (really stupid) issue, updated patch is located here:
http://www.mcmilk.de/projects/linux-bql/dl/0001-8139too-Support-for-byte-queue-limits.patch
The netif_dbg() statement will now also print the correct queued length.
--
Best regards, TR
next prev parent reply other threads:[~2013-10-14 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 18:26 [PATCHSET v1 00/07] Support for byte queue limits on various network interfaces Tino Reichardt
2013-10-14 18:26 ` [PATCH 01/07] 8139too: Support for byte queue limits Tino Reichardt
2013-10-14 19:11 ` Eric Dumazet
2013-10-14 19:31 ` Tino Reichardt
2013-10-14 19:52 ` Tino Reichardt [this message]
2013-10-14 18:26 ` [PATCH 02/07] r8169: " Tino Reichardt
2013-10-14 22:28 ` Francois Romieu
2013-10-14 18:26 ` [PATCH 03/03] tulip: " Tino Reichardt
2013-10-14 18:26 ` [PATCH 04/07] via-rhine: " Tino Reichardt
2013-10-14 18:26 ` [PATCH 05/07] via-velocity: " Tino Reichardt
2013-10-14 18:26 ` [PATCH 06/07] 3c59x: " Tino Reichardt
2013-10-14 18:26 ` [PATCH 07/07] natsemi: " Tino Reichardt
2013-10-14 18:41 ` [PATCHSET v1 00/07] Support for byte queue limits on various network interfaces Stephen Hemminger
2013-10-14 18:46 ` Tino Reichardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014195201.GD23070@mcmilk.de \
--to=list-linux-netdev@mcmilk.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.