From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] trace-cmd: use pkg-config instead of python-config
Date: Tue, 15 Oct 2013 09:30:03 +0200 [thread overview]
Message-ID: <20131015093003.1e213819@skate> (raw)
In-Reply-To: <525C72A3.9050008@openwide.fr>
Dear Romain Naour,
On Tue, 15 Oct 2013 00:39:31 +0200, Romain Naour wrote:
> > No, Python support is optional in trace-cmd. We should keep optional,
> > by doing:
> >
> > ifeq ($(BR2_PACKAGE_PYTHON),)
> > TRACE_CMD_MAKE_FLAGS += -NO_PYTHON=1
> > else
> > TRACE_CMD_DEPENDENCIES += python
> > endif
>
> What about python3 ?
> But python 2.7 seems to be good enough.
Enabling it against Python3 would be good indeed.
> > Python dependency should be optional. The pkg-config dependency should
> > be on host-pkg-config.
>
> host-pkgconf ?
Correct, my bad. It used to be host-pkg-config a while ago, and since
the binary name is still pkg-config, I've never managed to remember the
package name is now pkgconf.
> > http://patchwork.ozlabs.org/patch/279267/
> > http://patchwork.ozlabs.org/patch/279265/
> > http://patchwork.ozlabs.org/patch/279269/
> >
>
> I see that, my patch is a workaround and don't fix the real problem.
> But we can decide to not use python-config for cross-compilation.
>
> May I reuse your patch comments for v2 ?
Of course, please do.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-10-15 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 22:26 [Buildroot] [PATCH 1/1] trace-cmd: use pkg-config instead of python-config Romain Naour
2013-10-14 6:58 ` Thomas Petazzoni
2013-10-14 10:52 ` Peter Korsgaard
2013-10-14 22:39 ` Romain Naour
2013-10-15 7:30 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015093003.1e213819@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.