Re: [PATCH] drm/i915: Use pipe_name() instead of the pipe number

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use pipe_name() instead of the pipe number
Date: Tue, 15 Oct 2013 20:59:17 +0300	[thread overview]
Message-ID: <20131015175917.GQ13047@intel.com> (raw)
In-Reply-To: <1381844743-28488-1-git-send-email-damien.lespiau@intel.com>

On Tue, Oct 15, 2013 at 02:45:43PM +0100, Damien Lespiau wrote:
> Yet another direct usage of the pipe number instead of pipe_name().
> We've been tracking them lately but managed to miss this one.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

I actually see two more in intel_dsi.c and intel_panel.c.

> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index b9cede7..81f7fa5 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -10734,11 +10734,11 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
>  		}
>  
>  		encoder->connectors_active = false;
> -		DRM_DEBUG_KMS("[ENCODER:%d:%s] hw state readout: %s, pipe=%i\n",
> +		DRM_DEBUG_KMS("[ENCODER:%d:%s] hw state readout: %s, pipe %c\n",
>  			      encoder->base.base.id,
>  			      drm_get_encoder_name(&encoder->base),
>  			      encoder->base.crtc ? "enabled" : "disabled",
> -			      pipe);
> +			      pipe_name(pipe));
>  	}
>  
>  	list_for_each_entry(connector, &dev->mode_config.connector_list,
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC