From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 15 Oct 2013 20:06:38 +0200 Subject: [PATCH v10 2/7] ARM: hi3xxx: add board support with device tree In-Reply-To: References: <1381828577-27998-1-git-send-email-haojian.zhuang@linaro.org> <201310151500.36959.arnd@arndb.de> Message-ID: <201310152006.38824.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 15 October 2013, Haojian Zhuang wrote: > On 15 October 2013 21:00, Arnd Bergmann wrote: > > On Tuesday 15 October 2013, Haojian Zhuang wrote: > >> > >> Add board support with device tree for Hisilicon Hi3620 SoC platform. > >> > >> Changelog: > >> v10: > >> 1. Add .map_io() & debug_ll_io_init() back. Since debug_ll_io_init() is > >> only called if .map_io() isn't assigned. Use .map_io() to setup static > >> IO mapping that is used in clock driver. > >> > > > > This seems like a step in the wrong direction. Why would you want to use > > a static I/O mapping in the clock driver? > > > > Because Stephen & Kevin asked me to use unit address in DTS file. They > also require me to use reg property to present real hardware address > in DTS file. Ah, so it's just an optimization, not required to make the clock driver work, I misread that. Can you add a comment near the hi3620_io_desc definition and verify that it still works without it? I would also recommend to extend that static mapping to the entire 0xfc800000-0xfcbfffff range, or whatever you can use to get the most I/O devices with a small number of TLB entries. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v10 2/7] ARM: hi3xxx: add board support with device tree Date: Tue, 15 Oct 2013 20:06:38 +0200 Message-ID: <201310152006.38824.arnd@arndb.de> References: <1381828577-27998-1-git-send-email-haojian.zhuang@linaro.org> <201310151500.36959.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Haojian Zhuang Cc: Mark Rutland , devicetree@vger.kernel.org, Kevin Hilman , Russell King - ARM Linux , Shaojie Sun , Stephen Warren , Linus Walleij , Patch Tracking , Rob Herring , Grant Likely , John Stultz , Olof Johansson , Mike Turquette , "tglx@linutronix.de" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tuesday 15 October 2013, Haojian Zhuang wrote: > On 15 October 2013 21:00, Arnd Bergmann wrote: > > On Tuesday 15 October 2013, Haojian Zhuang wrote: > >> > >> Add board support with device tree for Hisilicon Hi3620 SoC platform. > >> > >> Changelog: > >> v10: > >> 1. Add .map_io() & debug_ll_io_init() back. Since debug_ll_io_init() is > >> only called if .map_io() isn't assigned. Use .map_io() to setup static > >> IO mapping that is used in clock driver. > >> > > > > This seems like a step in the wrong direction. Why would you want to use > > a static I/O mapping in the clock driver? > > > > Because Stephen & Kevin asked me to use unit address in DTS file. They > also require me to use reg property to present real hardware address > in DTS file. Ah, so it's just an optimization, not required to make the clock driver work, I misread that. Can you add a comment near the hi3620_io_desc definition and verify that it still works without it? I would also recommend to extend that static mapping to the entire 0xfc800000-0xfcbfffff range, or whatever you can use to get the most I/O devices with a small number of TLB entries. Arnd