diff for duplicates of <201310152018.10908.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index 761737b..4429a93 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Tuesday 15 October 2013, Haojian Zhuang wrote: > Enable Hisilicon Hi4511 development platform with device tree support. > -> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org> +> Signed-off-by: Haojian Zhuang <haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Based on my other mail, some more comments here: @@ -17,7 +17,7 @@ ranges to map the clocks into their own address space, like ranges = <0 0xfc802000 0x1000>; -> + timer4_mux: timer4_mux at fc802018 { +> + timer4_mux: timer4_mux@fc802018 { > + compatible = "hisilicon,clk-mux"; > + #clock-cells = <0>; > + clocks = <&osc32k &timerclk45>; @@ -29,7 +29,7 @@ ranges to map the clocks into their own address space, like which would turn this into - timer4_mux: timer4_mux at 18 { + timer4_mux: timer4_mux@18 { ... reg = <0x18 0x4>; ... @@ -39,7 +39,7 @@ The code would not be impacted by this. On a related note, I find it strange that you have multiple devices with the same register. Normally, we try to have device node names be generic, -e.g. 'clock at 18' rather than 'timer4_mux at 18', but that won't work if the +e.g. 'clock@18' rather than 'timer4_mux@18', but that won't work if the register is the same for all of them. Maybe some DT expert can comment on this. @@ -66,3 +66,7 @@ If you do that, it probably makes sense to move the clock controller under here as well. Arnd +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 57d7918..4efe2b9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,15 +1,31 @@ "ref\01381828577-27998-1-git-send-email-haojian.zhuang@linaro.org\0" "ref\01381828577-27998-4-git-send-email-haojian.zhuang@linaro.org\0" - "From\0arnd@arndb.de (Arnd Bergmann)\0" - "Subject\0[PATCH v10 3/7] ARM: dts: enable hi4511 with device tree\0" + "ref\01381828577-27998-4-git-send-email-haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org\0" + "From\0Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>\0" + "Subject\0Re: [PATCH v10 3/7] ARM: dts: enable hi4511 with device tree\0" "Date\0Tue, 15 Oct 2013 20:18:10 +0200\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Haojian Zhuang <haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\0" + "Cc\0linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" + linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org + rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org + john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + mark.rutland-5wv7dgnIgG8@public.gmane.org + khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org + shaojie.sun-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org + devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org\0" "\00:1\0" "b\0" "On Tuesday 15 October 2013, Haojian Zhuang wrote:\n" "> Enable Hisilicon Hi4511 development platform with device tree support.\n" "> \n" - "> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>\n" + "> Signed-off-by: Haojian Zhuang <haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>\n" "\n" "Based on my other mail, some more comments here:\n" "\n" @@ -25,7 +41,7 @@ "\t\tranges = <0 0xfc802000 0x1000>;\n" "\n" "\n" - "> +\t\ttimer4_mux: timer4_mux at fc802018 {\n" + "> +\t\ttimer4_mux: timer4_mux@fc802018 {\n" "> +\t\t\tcompatible = \"hisilicon,clk-mux\";\n" "> +\t\t\t#clock-cells = <0>;\n" "> +\t\t\tclocks = <&osc32k &timerclk45>;\n" @@ -37,7 +53,7 @@ "\n" "which would turn this into \n" "\n" - "\t\ttimer4_mux: timer4_mux at 18 {\n" + "\t\ttimer4_mux: timer4_mux@18 {\n" "\t\t\t...\n" "\t\t\treg = <0x18 0x4>;\n" "\t\t\t...\n" @@ -47,7 +63,7 @@ "\n" "On a related note, I find it strange that you have multiple devices with the\n" "same register. Normally, we try to have device node names be generic,\n" - "e.g. 'clock at 18' rather than 'timer4_mux at 18', but that won't work if the\n" + "e.g. 'clock@18' rather than 'timer4_mux@18', but that won't work if the\n" "register is the same for all of them. Maybe some DT expert can comment\n" "on this.\n" "\n" @@ -73,6 +89,10 @@ "If you do that, it probably makes sense to move the clock controller under here\n" "as well.\n" "\n" - "\tArnd" + "\tArnd\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -e137287de76fda063c72484465d030773b1f198ad980670a3902f3eb422b0f4a +57468cbc5934f1088cc3b1a8595c03b07e24174cb32750429c90acff41311153
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.