All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: mxs: Do not reconfigure FEC clock in FEC init
Date: Tue, 15 Oct 2013 23:19:33 +0200	[thread overview]
Message-ID: <201310152319.34204.marex@denx.de> (raw)
In-Reply-To: <525BAC91.5080703@denx.de>

Dear Stefano Babic,

> Hi Marek,
> 
> On 13/10/2013 17:20, Marek Vasut wrote:
> > Do not reconfigure the FEC clock during board_eth_init(), otherwise
> > the FEC might have stability issues, refuse to autonegotiate link
> > entirely or even corrupt packets while indicating correct checksum
> > on them. Instead, move the FEC clock init to board_early_init_f(),
> > where all the other upstream clock are initialized and also make
> > sure there is proper stabilization delay.
> 
> However, it seems to me that moving the code remove the problem on the
> mx28evk without finding the cause. Really there is still a big chunk of
> time between the initialization of the clock and the first packet is
> sent to the network, when the autonegotiation should occur.

Forget this, the issue is still present. Damn!

It's at least a little clearer to me what happens now. The FEC fails to transmit 
an TFTP block ACK packet -> the server waits 5 seconds -> sends ARP packet -> 
FEC replies and resends the TFTP block ACK again. Why does the FEC swallow a TX 
packet, I don't know.

Best regards,
Marek Vasut

  reply	other threads:[~2013-10-15 21:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-13 15:20 [U-Boot] [PATCH] ARM: mxs: Do not reconfigure FEC clock in FEC init Marek Vasut
2013-10-13 20:20 ` Marek Vasut
2013-10-14  7:46 ` Hector Palacios
2013-10-14  8:17 ` Hector Palacios
2013-10-14  8:34 ` Stefano Babic
2013-10-15 21:19   ` Marek Vasut [this message]
2013-10-16  9:10     ` Stefano Babic
2013-10-16 14:06       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310152319.34204.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.