From: Antonio Quartulli <antonio@meshcoding.com>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: generalize batman-adv icmp packet handling
Date: Wed, 16 Oct 2013 08:16:14 +0200 [thread overview]
Message-ID: <20131016061614.GA2596@neomailbox.net> (raw)
In-Reply-To: <1779622.xWDEdjCAYf@diderot>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Wed, Oct 16, 2013 at 01:59:18PM +0800, Marek Lindner wrote:
> On Tuesday 15 October 2013 21:20:23 Antonio Quartulli wrote:
> > > Besides, if we make everything generic batadv_socket_packet->icmp_packet
> > > should not be hard-coded to batadv_icmp_packet_rr but the largest
> > > available
> > > ICMP packet type ?
> >
> > or we dynamically allocate a buffer of size 'len'? In this way we don't need
> > to change icmp_packet each time (hopefully not so many but still..) the
> > "largest available ICMP packet type" changes.
>
> Allocating a dynamic buffer does not solve the underlying issue. At some point
> we would want to check the packet size - either through sizeof(socket_packet-
> >icmp_packet) or a macro or whatever.
> Take a look at batadv_max_header_len() for an idea how to address the matter.
>
Right. Thanks for the clarification
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-10-16 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 16:08 [B.A.T.M.A.N.] [PATCH] batman-adv: generalize batman-adv icmp packet handling Simon Wunderlich
2013-10-15 8:04 ` Marek Lindner
2013-10-15 19:20 ` Antonio Quartulli
2013-10-16 5:59 ` Marek Lindner
2013-10-16 6:16 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016061614.GA2596@neomailbox.net \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.