From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934328Ab3JPMnV (ORCPT ); Wed, 16 Oct 2013 08:43:21 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:35777 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932406Ab3JPMnU (ORCPT ); Wed, 16 Oct 2013 08:43:20 -0400 Date: Wed, 16 Oct 2013 18:13:12 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ingo Molnar , Anton Arapov , David Smith , "Frank Ch. Eigler" , Martin Cermak , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] uprobes: Teach __create_xol_area() to accept the predefined vaddr Message-ID: <20131016124312.GF19729@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20131013191815.GA32466@redhat.com> <20131013191838.GA32490@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20131013191838.GA32490@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13101612-3532-0000-0000-000002354124 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Oleg Nesterov [2013-10-13 21:18:38]: > Currently xol_add_vma() uses get_unmapped_area() for area->vaddr, > but the next patches need to use the fixed address. So this patch > adds the new "vaddr" argument to __create_xol_area() which should > be used as area->vaddr if it is nonzero. > > xol_add_vma() doesn't bother to verify that the predefined addr is > not used, insert_vm_struct() should fail if find_vma_links() detects > the overlap with the existing vma. > > Also, __create_xol_area() doesn't need __GFP_ZERO to allocate area. > > Cc: stable@vger.kernel.org # 3.9+ > Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju