From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock
Date: Wed, 16 Oct 2013 18:21:09 +0100 [thread overview]
Message-ID: <20131016172109.GX23150@redhat.com> (raw)
In-Reply-To: <1381943828-7948-1-git-send-email-pbonzini@redhat.com>
On Wed, Oct 16, 2013 at 07:17:08PM +0200, Paolo Bonzini wrote:
> This lock does not protect anything that the BQL does not already
> protect. Furthermore, with -nodefaults and no monitor, the mutex
> is not initialized but monitor_protocol_event_queue is called
> anyway, which causes a crash under mingw (and only works by luck.
> under Linux or other POSIX OSes).
>
> Reported-by: Orx Goshen <orx.goshen@intel.com>
> Cc: Daniel Berrange <berrange@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Maybe I'm missing something?
ACK, I only added it because I wasn't clear on
wether the BQL was sufficient, so it was just a
safety net.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2013-10-16 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 17:17 [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock Paolo Bonzini
2013-10-16 17:21 ` Daniel P. Berrange [this message]
2013-10-17 12:45 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016172109.GX23150@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.