From: Greg KH <gregkh@linuxfoundation.org>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: Dhanunjaya <dhanunjaya.matrix@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: xillybus: fix for quoted string split across lines
Date: Wed, 16 Oct 2013 12:09:38 -0700 [thread overview]
Message-ID: <20131016190938.GA19071@kroah.com> (raw)
In-Reply-To: <525EDFAF.8030306@gmail.com>
On Wed, Oct 16, 2013 at 09:49:19PM +0300, Eli Billauer wrote:
> Hello Greg,
>
> On 16/10/13 21:06, Greg KH wrote:
> >> rc = of_address_to_resource(dev->of_node, 0,&endpoint->res);
> >>> if (rc) {
> >>> - pr_warn("xillybus: Failed to obtain device tree "
> >>> - "resource\n");
> >>> + pr_warn("xillybus: Failed to obtain device tree resource\n");
> >This should be using dev_warn() instead.
> >
>
> So I understand that I should replace *all* occurrences of pr_warn()
> and pr_err() with their dev_* counterparts?
Yes.
prev parent reply other threads:[~2013-10-16 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 17:57 [PATCH 2/2] Staging: xillybus: fix for quoted string split across lines Dhanunjaya
2013-10-16 18:06 ` Greg KH
2013-10-16 18:49 ` Eli Billauer
2013-10-16 19:09 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016190938.GA19071@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dhanunjaya.matrix@gmail.com \
--cc=eli.billauer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.