From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH 1/3] switch_creds:  Syscall to switch creds for file
 server ops
Date: Thu, 17 Oct 2013 02:20:50 +0100
Message-ID: <20131017012050.GR13318@ZenIV.linux.org.uk>
References: <1381960919-4542-1-git-send-email-jlieb@panasas.com>
 <1381960919-4542-2-git-send-email-jlieb@panasas.com>
 <20131016224248.GQ13318@ZenIV.linux.org.uk>
 <87ppr4lmp3.fsf@xmission.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jim Lieb <jlieb@panasas.com>, tytso@mit.edu, viro@zeniv.linux.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	bfields@redhat.com, jlayton@redhat.com
To: "Eric W. Biederman" <ebiederm@xmission.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <87ppr4lmp3.fsf@xmission.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Oct 16, 2013 at 06:18:16PM -0700, Eric W. Biederman wrote:

> That doesn't look bad but it does need capable(CAP_SETUID) &&
> capable(CAP_SETGID) or possibly something a little more refined.

D'oh

> I don't think we want file descriptor passing to all of a sudden become
> a grant of privilege, beyond what the passed fd can do.

Definitely.  And an extra ) to make it compile wouldn't hurt either...