All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	edivaldoapereira@yahoo.com.br
Subject: Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag
Date: Thu, 17 Oct 2013 10:20:04 +0200	[thread overview]
Message-ID: <20131017082004.GD10774@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1381830350-7240-1-git-send-email-famz@redhat.com>

On Tue, Oct 15, 2013 at 05:45:50PM +0800, Fam Zheng wrote:
> Since 0ebd24e0, cdrom doesn't have read-only on by default, which will
> error out when using an read only image. Fix it by setting the default
> value when parsing opts.
> 
> Reported-by: Edivaldo de Araujo Pereira <edivaldoapereira@yahoo.com.br>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> 
> ---
> v2: fix backward compatibility by force read-only with cdrom. (Kevin)
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  blockdev.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

  parent reply	other threads:[~2013-10-17  8:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-15  9:45 [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag Fam Zheng
2013-10-15 11:07 ` Kevin Wolf
2013-10-17  8:20 ` Stefan Hajnoczi [this message]
2013-11-05  6:25 ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017082004.GD10774@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=edivaldoapereira@yahoo.com.br \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.