All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: anthony@codemonkey.ws, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: update nic info during device reset
Date: Thu, 17 Oct 2013 12:34:40 +0300	[thread overview]
Message-ID: <20131017093440.GE14596@redhat.com> (raw)
In-Reply-To: <1381999114-3596-1-git-send-email-akong@redhat.com>

On Thu, Oct 17, 2013 at 04:38:34PM +0800, Amos Kong wrote:
> macaddr is reset during device reset, but nic info
> isn't updated, this problem exists in e1000 & rtl8139
> 
> Signed-off-by: Amos Kong <akong@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/net/e1000.c   | 1 +
>  hw/net/rtl8139.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/hw/net/e1000.c b/hw/net/e1000.c
> index 7769be0..70a59fd 100644
> --- a/hw/net/e1000.c
> +++ b/hw/net/e1000.c
> @@ -401,6 +401,7 @@ static void e1000_reset(void *opaque)
>          d->mac_reg[RA] |= macaddr[i] << (8 * i);
>          d->mac_reg[RA + 1] |= (i < 2) ? macaddr[i + 4] << (8 * i) : 0;
>      }
> +    qemu_format_nic_info_str(qemu_get_queue(d->nic), macaddr);
>  }
>  
>  static void
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index 248d9e9..3225f3d 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -1214,6 +1214,7 @@ static void rtl8139_reset(DeviceState *d)
>  
>      /* restore MAC address */
>      memcpy(s->phys, s->conf.macaddr.a, 6);
> +    qemu_format_nic_info_str(qemu_get_queue(s->nic), s->phys);
>  
>      /* reset interrupt mask */
>      s->IntrStatus = 0;
> -- 
> 1.8.3.1

  reply	other threads:[~2013-10-17  9:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17  8:38 [Qemu-devel] [PATCH] net: update nic info during device reset Amos Kong
2013-10-17  9:34 ` Michael S. Tsirkin [this message]
2013-10-18 11:26 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017093440.GE14596@redhat.com \
    --to=mst@redhat.com \
    --cc=akong@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.