From: Antonio Quartulli <antonio@open-mesh.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Antonio Quartulli <antonio@meshcoding.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net] bridge: clean the nf_bridge status when forwarding the skb
Date: Thu, 17 Oct 2013 13:37:35 +0200 [thread overview]
Message-ID: <20131017113735.GB2699@open-mesh.com> (raw)
In-Reply-To: <20131017112857.GA11318@localhost>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Thu, Oct 17, 2013 at 04:28:57AM -0700, Pablo Neira Ayuso wrote:
> Hi,
> > +
> > +/**
> > + * br_netfilter_skb_free - clean the NF bridge data in an skb
> > + * @skb: the skb which the data to free belongs to
> > + */
> > +void br_netfilter_skb_free(struct sk_buff *skb)
> > +{
> > + nf_bridge_put(skb->nf_bridge);
> > + skb->nf_bridge = NULL;
> > +}
>
> This should be nf_reset.
You think I should directly use nf_reset instead of this function?
I see that nf_reset() cleans up the conntrack part too: does it also become
useless once the packet exits the bridge interface?
Cheers,
--
Antonio Quartulli
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-17 11:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 22:51 [PATCH net] bridge: clean the nf_bridge status when forwarding the skb Antonio Quartulli
2013-10-17 11:28 ` Pablo Neira Ayuso
2013-10-17 11:37 ` Antonio Quartulli [this message]
2013-10-18 11:10 ` Pablo Neira Ayuso
2013-10-18 11:35 ` Antonio Quartulli
2013-10-18 14:32 ` Vlad Yasevich
2013-10-18 14:46 ` Antonio Quartulli
2013-10-18 15:33 ` Vlad Yasevich
2013-10-18 15:41 ` Antonio Quartulli
2013-10-21 15:00 ` Vlad Yasevich
2013-10-21 15:06 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017113735.GB2699@open-mesh.com \
--to=antonio@open-mesh.com \
--cc=antonio@meshcoding.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.