From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/2] drm/i915: set HDMI pixel clock in audio configuration
Date: Thu, 17 Oct 2013 14:40:34 +0200 [thread overview]
Message-ID: <20131017124034.GT4830@phenom.ffwll.local> (raw)
In-Reply-To: <CABVU7+s0K1+Xxi91MnD4yO5raFbTQcGnSKOmzpeUfiSrgwPLtA@mail.gmail.com>
On Thu, Oct 17, 2013 at 09:01:52AM -0300, Rodrigo Vivi wrote:
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
>
> On Wed, Oct 16, 2013 at 6:34 AM, Jani Nikula <jani.nikula@intel.com> wrote:
> > The HDMI audio expects HDMI pixel clock to be set in the audio
> > configuration. We've currently just set 0, using 25.2 / 1.001 kHz
> > frequency, which fails with some modes.
> >
> > v2: Now with a commit message.
> >
> > Reference: http://mid.gmane.org/CAGpEb3Ep1LRZETPxHGRfBDqr5Ts2tAc8gCukWwugUf1U5NYv1g@mail.gmail.com
> > Reference: http://mid.gmane.org/20130206213533.GA16367@hardeman.nu
> > Reported-by: David Härdeman <david@hardeman.nu>
> > Reported-by: Jasper Smet <josbeir@gmail.com>
> > Tested-by: Jasper Smet <josbeir@gmail.com>
> > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Both merged, thanks for patches and review.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-10-17 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <id:cover.1381765995.git.jani.nikula@intel.com>
2013-10-16 9:34 ` [PATCH v2 1/2] drm/i915: pass mode to ELD write vfuncs Jani Nikula
2013-10-16 9:34 ` [PATCH v2 2/2] drm/i915: set HDMI pixel clock in audio configuration Jani Nikula
2013-10-17 12:01 ` Rodrigo Vivi
2013-10-17 12:40 ` Daniel Vetter [this message]
2013-10-24 9:07 ` Jasper Smet
2013-10-24 9:59 ` David Härdeman
2013-10-27 12:39 ` Daniel Vetter
2013-10-16 9:38 ` [PATCH v2 1/2] drm/i915: pass mode to ELD write vfuncs Jani Nikula
2013-10-17 12:02 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131017124034.GT4830@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.