All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function
Date: Thu, 17 Oct 2013 17:58:23 +0900	[thread overview]
Message-ID: <20131017175823.7EC6.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20131017105248.64260882@lilith>

Hello Albert.


> > Commit 27af930e adjusted this part like follows:
> > 
> > 
> >                     -v field="$1" \
> >                     -v select="$2" \
> >                     -F "$FS" \
> >     -               '($1 !~ /^#/ && $field == select) { print $1 }' \
> >     +               '($1 !~ /^#/ && $field == select) { print $7 }' \
> >                     boards.cfg
> >      }
> >      boards_by_arch() { boards_by_field 2 "$@" ; }
> >      boards_by_cpu()  { boards_by_field 3 "$@" "[: \t]+" ; }
> >     -boards_by_soc()  { boards_by_field 6 "$@" ; }
> >     +boards_by_soc()  { boards_by_field 4 "$@" ; }
> > 
> > 
> > TAB is also treated as a field speparator, so
> > we should have taken the 8th field for Tegra
> > whereas the 7th field for the other cpus.
> > 
> > Fortunately, Board Name field and Target filed are the same
> > for all Tegra LSIs.
> > But we should not expect it.
> 
> Not sure I am following here, as the commit you mention does not
> change how tabs are processed.
> 
> Besides, the system should *not* be sensitive to tabs. If it is, this
> must be fixed and tabs removed.


Sorry, my mistake.

s/TAB/colon/


The comment should be:

Colon is also treated as a field speparator, so
we should have taken the 8th field for Tegra
whereas the 7th field for the other cpus.



Best Regards
Masahiro Yamada

  reply	other threads:[~2013-10-17  8:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-17  7:37 [U-Boot] [PATCH 0/3] Fix bugs of MAKEALL Masahiro Yamada
2013-10-17  7:37 ` [U-Boot] [PATCH 1/3] MAKEALL: fix awk warning message Masahiro Yamada
2013-10-17  7:37 ` [U-Boot] [PATCH 2/3] MAKEALL: fix a bug to use CROSS_COMPILE_<ARCH> Masahiro Yamada
2013-10-17  8:33   ` Albert ARIBAUD
2013-10-17  8:48     ` Masahiro Yamada
2013-10-17  9:27       ` Albert ARIBAUD
2013-10-17 10:09         ` Masahiro Yamada
2013-10-17  7:37 ` [U-Boot] [PATCH 3/3] MAKEALL: fix boards_by_field function Masahiro Yamada
2013-10-17  8:52   ` Albert ARIBAUD
2013-10-17  8:58     ` Masahiro Yamada [this message]
2013-10-17  9:41   ` Albert ARIBAUD
2013-10-17 10:32     ` Masahiro Yamada
2013-10-17 11:41       ` Albert ARIBAUD
2013-10-18  6:37         ` Masahiro Yamada
2013-10-21 10:09         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131017175823.7EC6.AA925319@jp.panasonic.com \
    --to=yamada.m@jp.panasonic.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.