From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do hw quiescing first during unload
Date: Fri, 18 Oct 2013 10:36:30 +0300 [thread overview]
Message-ID: <20131018073630.GK13047@intel.com> (raw)
In-Reply-To: <20131017210434.GC16575@bwidawsk.net>
On Thu, Oct 17, 2013 at 02:04:34PM -0700, Ben Widawsky wrote:
> On Thu, Oct 17, 2013 at 08:37:44PM +0100, Chris Wilson wrote:
> > On Thu, Oct 17, 2013 at 12:07:26PM -0700, Ben Widawsky wrote:
> > > On Thu, Oct 17, 2013 at 01:02:53PM +0100, Chris Wilson wrote:
> > > > If we force the hw to idle as our first step during unload, we can abort
> > > > the unload upon failure. Later we can probe whether the hardware remain
> > > > active even after we try to shut it down.
> > > >
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > >
> > > Isn't it pretty mean to fail to unload? Wouldn't pci_clear_master yield
> > > what we want?
> >
> > It may be mean, but it seems to me to be the right thing to do if we
> > cannot turn off the hardware to unload the driver...
> > -Chris
> >
> > --
> > Chris Wilson, Intel Open Source Technology Centre
>
> And what about my suggestion of simply using pci_clear_master?
Might that hang some boxes?
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2013-10-18 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 12:02 [PATCH] drm/i915: Do hw quiescing first during unload Chris Wilson
2013-10-17 19:07 ` Ben Widawsky
2013-10-17 19:37 ` Chris Wilson
2013-10-17 21:04 ` Ben Widawsky
2013-10-17 21:19 ` Chris Wilson
2013-10-18 7:36 ` Ville Syrjälä [this message]
2013-10-18 18:09 ` Ben Widawsky
2013-10-18 18:18 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018073630.GK13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.