From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
"x86@kernel.org" <x86@kernel.org>,
"Wang, Xiaoming" <xiaoming.wang@intel.com>,
"Li, Zhuangzhi" <zhuangzhi.li@intel.com>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>
Subject: Re: [PATCH] x86: Remove WARN_ON(in_nmi()) from vmalloc_fault
Date: Fri, 18 Oct 2013 04:54:51 -0700 [thread overview]
Message-ID: <20131018115451.GM31306@linux.vnet.ibm.com> (raw)
In-Reply-To: <20131016155730.7fd55ac5@gandalf.local.home>
On Wed, Oct 16, 2013 at 03:57:30PM -0400, Steven Rostedt wrote:
> On Wed, 16 Oct 2013 12:36:32 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
>
> > > Ah but we have an in_interrupt() check in context_tracking_user_enter() that protects
> > > us against that.
> >
> > Here you are relying on the exception being treated as an interrupt,
> > correct?
>
> I don't think so. It's relying on nmi_enter() also makes in_interrupt()
> return true.
Got it, never mind!
Thanx, Paul
> Like I said before. An NMI interrupting userspace should be no
> different than an interrupt interrupting userspace. They both can
> trigger vmalloc faults, and we should be able to deal with it.
>
> -- Steve
>
next prev parent reply other threads:[~2013-10-18 11:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 20:39 [PATCH] x86: Remove WARN_ON(in_nmi()) from vmalloc_fault Steven Rostedt
2013-10-16 6:11 ` Ingo Molnar
2013-10-16 12:42 ` Steven Rostedt
2013-10-16 12:51 ` Ingo Molnar
2013-10-16 13:01 ` Borislav Petkov
2013-10-16 13:03 ` Steven Rostedt
2013-10-17 0:29 ` Liu, Chuansheng
2013-10-16 11:40 ` Frederic Weisbecker
2013-10-16 12:45 ` Steven Rostedt
2013-10-16 13:08 ` Frederic Weisbecker
2013-10-16 13:14 ` Steven Rostedt
2013-10-16 13:28 ` Frederic Weisbecker
2013-10-16 13:37 ` Steven Rostedt
2013-10-16 19:39 ` Paul E. McKenney
2013-10-16 19:36 ` Paul E. McKenney
2013-10-16 19:57 ` Steven Rostedt
2013-10-18 11:54 ` Paul E. McKenney [this message]
2013-10-17 13:59 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018115451.GM31306@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=fweisbec@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xiaoming.wang@intel.com \
--cc=zhuangzhi.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.