From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/4] drm: Constify struct drm_info_list * arguments Date: Fri, 18 Oct 2013 15:40:04 +0300 Message-ID: <20131018124004.GQ13047@intel.com> References: <1382033396-1400-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id EEF15E5EA8 for ; Fri, 18 Oct 2013 05:40:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1382033396-1400-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Damien Lespiau Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Oct 17, 2013 at 07:09:53PM +0100, Damien Lespiau wrote: > Those functions are just reading data from those pointers. > = > Signed-off-by: Damien Lespiau Reviewed-by: Ville Syrj=E4l=E4 for the series. > --- > drivers/gpu/drm/drm_debugfs.c | 4 ++-- > include/drm/drmP.h | 9 +++++---- > 2 files changed, 7 insertions(+), 6 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c > index a05087c..4813ff1 100644 > --- a/drivers/gpu/drm/drm_debugfs.c > +++ b/drivers/gpu/drm/drm_debugfs.c > @@ -84,7 +84,7 @@ static const struct file_operations drm_debugfs_fops = =3D { > * Create a given set of debugfs files represented by an array of > * gdm_debugfs_lists in the given root directory. > */ > -int drm_debugfs_create_files(struct drm_info_list *files, int count, > +int drm_debugfs_create_files(const struct drm_info_list *files, int coun= t, > struct dentry *root, struct drm_minor *minor) > { > struct drm_device *dev =3D minor->dev; > @@ -188,7 +188,7 @@ int drm_debugfs_init(struct drm_minor *minor, int min= or_id, > * > * Remove all debugfs entries created by debugfs_init(). > */ > -int drm_debugfs_remove_files(struct drm_info_list *files, int count, > +int drm_debugfs_remove_files(const struct drm_info_list *files, int coun= t, > struct drm_minor *minor) > { > struct list_head *pos, *q; > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index 2b954ad..c3b659a 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -1470,10 +1470,11 @@ extern struct drm_local_map *drm_getsarea(struct = drm_device *dev); > #if defined(CONFIG_DEBUG_FS) > extern int drm_debugfs_init(struct drm_minor *minor, int minor_id, > struct dentry *root); > -extern int drm_debugfs_create_files(struct drm_info_list *files, int cou= nt, > - struct dentry *root, struct drm_minor *minor); > -extern int drm_debugfs_remove_files(struct drm_info_list *files, int cou= nt, > - struct drm_minor *minor); > +extern int drm_debugfs_create_files(const struct drm_info_list *files, > + int count, struct dentry *root, > + struct drm_minor *minor); > +extern int drm_debugfs_remove_files(const struct drm_info_list *files, > + int count, struct drm_minor *minor); > extern int drm_debugfs_cleanup(struct drm_minor *minor); > #endif > = > -- = > 1.8.3.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel OTC