From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915/dp: don't mention eDP bpp clamping if it doesn't affect bpp Date: Fri, 18 Oct 2013 16:05:11 +0200 Message-ID: <20131018140511.GZ4830@phenom.ffwll.local> References: <1381932378-14890-1-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 7046EE6350 for ; Fri, 18 Oct 2013 07:04:51 -0700 (PDT) Received: by mail-ee0-f47.google.com with SMTP id d49so2067525eek.34 for ; Fri, 18 Oct 2013 07:04:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1381932378-14890-1-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Oct 16, 2013 at 05:06:17PM +0300, Jani Nikula wrote: > Signed-off-by: Jani Nikula > > --- > > This is useful with the follow-up patch that frobs > dev_priv->vbt.edp_bpp, and the value no longer comes directly from VBT. Same as for Ben's patch: Such prep-patch justifications should imo be part of the commit message. I've moved it. -Daniel > --- > drivers/gpu/drm/i915/intel_dp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index e4fdedc..f63aa8c 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -822,10 +822,11 @@ intel_dp_compute_config(struct intel_encoder *encoder, > /* Walk through all bpp values. Luckily they're all nicely spaced with 2 > * bpc in between. */ > bpp = pipe_config->pipe_bpp; > - if (is_edp(intel_dp) && dev_priv->vbt.edp_bpp) { > + if (is_edp(intel_dp) && dev_priv->vbt.edp_bpp && > + dev_priv->vbt.edp_bpp < bpp) { > DRM_DEBUG_KMS("clamping bpp for eDP panel to BIOS-provided %i\n", > dev_priv->vbt.edp_bpp); > - bpp = min_t(int, bpp, dev_priv->vbt.edp_bpp); > + bpp = dev_priv->vbt.edp_bpp; > } > > for (; bpp >= 6*3; bpp -= 2*3) { > -- > 1.7.9.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch