From: Dan Carpenter <dan.carpenter@oracle.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] hwmon: (tmp401) Convert to use devm_hwmon_device_register_with_groups
Date: Fri, 18 Oct 2013 14:25:06 +0000 [thread overview]
Message-ID: <20131018142506.GA25585@longonot.mountain> (raw)
Hello Guenter Roeck,
The patch 9aeb5c70e84d: "hwmon: (tmp401) Convert to use
devm_hwmon_device_register_with_groups" from Sep 4, 2013, leads to
the following warning:
"drivers/hwmon/tmp401.c:360 store_temp()
warn: 'data' isn't an ERR_PTR"
drivers/hwmon/tmp401.c
349 static ssize_t store_temp(struct device *dev, struct device_attribute *devattr,
350 const char *buf, size_t count)
351 {
352 int nr = to_sensor_dev_attr_2(devattr)->nr;
353 int index = to_sensor_dev_attr_2(devattr)->index;
354 struct tmp401_data *data = dev_get_drvdata(dev);
^^^^^^^^^^^^^^^^^^^
Returns NULL.
355 struct i2c_client *client = data->client;
^^^^^^^^^^^^
Dereference.
356 long val;
357 u16 reg;
358 u8 regaddr;
359
360 if (IS_ERR(data))
^^^^^^^^^^^^
Can this test be removed?
361 return PTR_ERR(data);
362
regards,
dan carpenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2013-10-18 14:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 14:25 Dan Carpenter [this message]
2013-10-18 16:13 ` [lm-sensors] hwmon: (tmp401) Convert to use devm_hwmon_device_register_with_groups Guenter Roeck
2013-10-19 8:24 ` Dan Carpenter
2013-11-06 19:28 ` Dan Carpenter
2013-11-06 19:39 ` Guenter Roeck
2013-11-06 20:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018142506.GA25585@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.