From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] usb: ums: move ums code from trats to Samsung common directory
Date: Fri, 18 Oct 2013 15:58:44 +0200 [thread overview]
Message-ID: <201310181558.45116.marex@denx.de> (raw)
In-Reply-To: <52611DD3.5010002@samsung.com>
Dear Przemyslaw Marczak,
> Hello Marek,
> Thank you for fast reply.
>
> On 10/17/2013 07:39 PM, Marek Vasut wrote:
> > Dear Przemyslaw Marczak,
> >
> >> UMS init was implemented in trats board file but mostly it comprises
> >> common code. Due to that it has been moved to common/ums.c to avoid
> >> code duplication in the future.
> >>
> >> Changes:
> >> - move ums initialization code from trats to common/ums.c
> >> - remove unused CONFIG_USB_GADGET_MASS_STORAGE from trats.h
> >>
> >> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> >> Cc: Marek Vasut <marex@denx.de>
> >> Cc: Minkyu Kang <mk7.kang@samsung.com>
> >> Cc: Lukasz Majewski <l.majewski@samsung.com>
> >> ---
> >>
> >> board/samsung/common/Makefile | 1 +
> >> board/samsung/common/ums.c | 66
> >>
> >> +++++++++++++++++++++++++++++++++++++++++ board/samsung/trats/trats.c
> >> |
> >>
> >> 62 -------------------------------------- include/configs/trats.h
> >> |
> >>
> >> 2 --
> >>
> >> 4 files changed, 67 insertions(+), 64 deletions(-)
> >> create mode 100644 board/samsung/common/ums.c
> >>
> >> diff --git a/board/samsung/common/Makefile
> >> b/board/samsung/common/Makefile index ad7564c..d122169 100644
> >> --- a/board/samsung/common/Makefile
> >> +++ b/board/samsung/common/Makefile
> >> @@ -11,6 +11,7 @@ LIB = $(obj)libsamsung.o
> >>
> >> COBJS-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
> >> COBJS-$(CONFIG_THOR_FUNCTION) += thor.o
> >>
> >> +COBJS-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
> >>
> >> SRCS := $(COBJS-y:.o=.c)
> >> OBJS := $(addprefix $(obj),$(COBJS-y))
> >>
> >> diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c
> >> new file mode 100644
> >> index 0000000..506f4b5
> >> --- /dev/null
> >> +++ b/board/samsung/common/ums.c
> >> @@ -0,0 +1,66 @@
> >> +/*
> >> + * Copyright (C) 2013 Samsung Electronics
> >> + * Lukasz Majewski <l.majewski@samsung.com>
> >> + *
> >> + * SPDX-License-Identifier: GPL-2.0+
> >> + */
> >> +
> >> +#include <common.h>
> >> +#include <usb_mass_storage.h>
> >> +#include <part.h>
> >> +
> >> +static int ums_read_sector(struct ums_device *ums_dev,
> >> + ulong start, lbaint_t blkcnt, void *buf)
> >> +{
> >> + if (ums_dev->mmc->block_dev.block_read(ums_dev->dev_num,
> >> + start + ums_dev->offset, blkcnt,
> >> + buf) != blkcnt)
> >
> > This looks like hell.
> >
> > typeT block_dev = ums_dev->mmc;
> > int ret;
> >
> > ret = block_dev->block_read(....);
> >
> > return ret;
>
> Ok, you're right - I will fix it in next patch set.
>
> > Is it necessary to return -1? Why ?
>
> It's only because of ums gadged driver design but it is easy to simplify.
A proper errno.h patch would be good here.
> > Please fix the whole thing in-place first, then rebase this migration
> > patch on top of the fix.
>
> OK, migration patch will be at the top.
>
> And one more. Do you want me to make it applicable to usb-next or
> usb-master tree?
-next please.
next prev parent reply other threads:[~2013-10-18 13:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 13:21 [U-Boot] [PATCH 0/4] USB: UMS: code refactoring and usage improvement Przemyslaw Marczak
2013-10-16 13:21 ` [U-Boot] [PATCH 1/4] usb: ums: move ums code from trats to Samsung common directory Przemyslaw Marczak
2013-10-17 17:39 ` Marek Vasut
2013-10-18 11:38 ` Przemyslaw Marczak
2013-10-18 13:58 ` Marek Vasut [this message]
2013-10-16 13:21 ` [U-Boot] [PATCH 2/4] usb: ums: code refactoring to improve reusability at other boards Przemyslaw Marczak
2013-10-16 13:21 ` [U-Boot] [PATCH 3/4] usb: ums: fix bug in partition capacity computation Przemyslaw Marczak
2013-10-17 17:41 ` Marek Vasut
2013-10-18 15:05 ` Przemyslaw Marczak
2013-10-19 0:57 ` Marek Vasut
2013-10-22 11:04 ` Przemyslaw Marczak
2013-10-16 13:21 ` [U-Boot] [PATCH 4/4] usb: ums: add ums exit feature by ctrl+c or by detach usb cable Przemyslaw Marczak
2013-10-17 17:43 ` Marek Vasut
2013-10-23 12:30 ` [U-Boot] [PATCH v2 0/5] USB: UMS: code refactoring and usage improvement Przemyslaw Marczak
2013-10-23 12:30 ` [U-Boot] [PATCH v2 1/5] usb: ums: code refactoring to improve reusability on other boards Przemyslaw Marczak
2013-10-27 18:18 ` Marek Vasut
2013-10-28 7:38 ` Lukasz Majewski
2013-10-28 8:47 ` Marek Vasut
2013-10-23 12:30 ` [U-Boot] [PATCH v2 2/5] usb: ums: allows using every mmc device with ums Przemyslaw Marczak
2013-10-23 12:30 ` [U-Boot] [PATCH v2 3/5] usb: ums: fix disk capacity miscalculation and code cleanup Przemyslaw Marczak
2013-10-23 12:30 ` [U-Boot] [PATCH v2 4/5] usb: ums: move ums code from trats to Samsung common directory Przemyslaw Marczak
2013-10-23 12:30 ` [U-Boot] [PATCH v2 5/5] usb: ums: add ums exit feature by ctrl+c or by detach usb cable Przemyslaw Marczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310181558.45116.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.