From: Dave Chinner <david@fromorbit.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: use minimum log size in xfs/016
Date: Sat, 19 Oct 2013 09:58:59 +1100 [thread overview]
Message-ID: <20131018225859.GA4446@dastard> (raw)
In-Reply-To: <1382116574-7766-1-git-send-email-bfoster@redhat.com>
On Fri, Oct 18, 2013 at 01:16:14PM -0400, Brian Foster wrote:
> Test xfs/016 fails to run due to invalid mkfs options. The log size
> is reported as too small according to the minimum log size
> calculation:
>
> log size 512 blocks too small, minimum size is 853 blocks
>
> Update log_size to the currently specified minimum.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
> tests/xfs/016 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/016 b/tests/xfs/016
> index 2fc6af2..e52f80c 100755
> --- a/tests/xfs/016
> +++ b/tests/xfs/016
> @@ -181,7 +181,7 @@ _supported_os Linux
> rm -f $seqres.full
>
> # mkfs sizes
> -log_size=2097152
> +log_size=3493888
> log_size_bb=`expr $log_size / 512`
That shoul dbe fine. I've been ignoring xfs/016 because the
configurations I test throw this:
xfs/016 21s ... [not run] Cannot mkfs for this test using MKFS_OPTIONS specified
And so I haven't noticed if it was failing or not.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-18 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 17:16 [PATCH] xfstests: use minimum log size in xfs/016 Brian Foster
2013-10-18 22:58 ` Dave Chinner [this message]
2013-10-22 21:13 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018225859.GA4446@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.