From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/i915: change power_well->lock to be mutex
Date: Sat, 19 Oct 2013 13:02:07 +0200 [thread overview]
Message-ID: <20131019110207.GC4830@phenom.ffwll.local> (raw)
In-Reply-To: <20131018115047.3fbfcc22@jbarnes-desktop>
On Fri, Oct 18, 2013 at 11:50:47AM -0700, Jesse Barnes wrote:
> Are there ordering requirements we should document? E.g. always take
> this after the mode config lock or something?
The mode_config lock is pretty much the outermost thing, and for getting
it right we have lockdpe. As long as we ensure that we have full coverage
with our tests and as long as QA doesn't fumble running the debug kernel
builds we should be fine. So imo no need to document the locking.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-10-19 11:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 14:25 [PATCH 0/6] preparation for multiple power-wells Imre Deak
2013-10-16 14:25 ` [PATCH 1/6] drm/i915: make the intel_display_power_domain enum compact Imre Deak
2013-10-18 18:48 ` Jesse Barnes
2013-10-16 14:25 ` [PATCH 2/6] drm/i915: factor out is_always_on_domain Imre Deak
2013-10-18 18:49 ` Jesse Barnes
2013-10-16 14:25 ` [PATCH 3/6] drm/i915: change power_well->lock to be mutex Imre Deak
2013-10-16 16:19 ` Paulo Zanoni
2013-10-16 16:31 ` Imre Deak
2013-10-18 18:50 ` Jesse Barnes
2013-10-19 11:02 ` Daniel Vetter [this message]
2013-10-16 14:25 ` [PATCH 4/6] drm/i915: factor out modeset_update_power_wells Imre Deak
2013-10-18 18:51 ` Jesse Barnes
2013-10-16 14:25 ` [PATCH 5/6] drm/i915: enable only the needed power domains during modeset Imre Deak
2013-10-18 18:53 ` Jesse Barnes
2013-10-22 20:07 ` Paulo Zanoni
2013-10-23 9:02 ` Imre Deak
2013-10-16 14:25 ` [PATCH 6/6] drm/i915: use power get/put instead of set for power on after init Imre Deak
2013-10-18 18:56 ` Jesse Barnes
2013-10-21 19:02 ` Daniel Vetter
2013-10-22 17:47 ` [PATCH 1/2] drm/i915: prepare for multiple power wells Imre Deak
2013-10-22 17:47 ` [PATCH v2 2/2] drm/i915: use power get/put instead of set for power on after init Imre Deak
2013-10-23 13:56 ` [PATCH 1/2] drm/i915: prepare for multiple power wells Paulo Zanoni
2013-10-23 14:46 ` Imre Deak
2013-10-25 14:36 ` [PATCH v3 0/4] " Imre Deak
2013-10-25 14:36 ` [PATCH v3 1/4] drm/i915: " Imre Deak
2013-10-25 14:36 ` [PATCH v3 2/4] drm/i915: use power get/put instead of set for power on after init Imre Deak
2013-10-25 19:31 ` Paulo Zanoni
2013-10-25 14:36 ` [PATCH v3 3/4] drm/i915: remove device field from struct power_well Imre Deak
2013-10-25 19:50 ` Paulo Zanoni
2013-10-27 19:30 ` Daniel Vetter
2013-10-28 17:41 ` Paulo Zanoni
2013-10-28 18:31 ` Imre Deak
2013-10-25 14:36 ` [PATCH v3 4/4] drm/i915: rename i915_init_power_well to i915_init_power_domains Imre Deak
2013-10-25 20:10 ` Paulo Zanoni
2013-10-27 12:44 ` Daniel Vetter
2013-10-28 15:20 ` [PATCH v4] drm/i915: rename i915_init_power_well to init_power_domains_init Imre Deak
2013-10-28 18:51 ` Paulo Zanoni
2013-10-29 17:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131019110207.GC4830@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.