From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/6] drm/i915: change power_well->lock to be mutex Date: Sat, 19 Oct 2013 13:02:07 +0200 Message-ID: <20131019110207.GC4830@phenom.ffwll.local> References: <1381933553-19529-1-git-send-email-imre.deak@intel.com> <1381933553-19529-4-git-send-email-imre.deak@intel.com> <20131018115047.3fbfcc22@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F047E5C54 for ; Sat, 19 Oct 2013 04:01:49 -0700 (PDT) Received: by mail-ee0-f45.google.com with SMTP id c50so2615314eek.18 for ; Sat, 19 Oct 2013 04:01:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20131018115047.3fbfcc22@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Oct 18, 2013 at 11:50:47AM -0700, Jesse Barnes wrote: > Are there ordering requirements we should document? E.g. always take > this after the mode config lock or something? The mode_config lock is pretty much the outermost thing, and for getting it right we have lockdpe. As long as we ensure that we have full coverage with our tests and as long as QA doesn't fumble running the debug kernel builds we should be fine. So imo no need to document the locking. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch