From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] firewire: info leak in ioctl_get_info()
Date: Sat, 19 Oct 2013 11:03:46 +0000 [thread overview]
Message-ID: <20131019130346.5f8ad3a5@stein> (raw)
In-Reply-To: <20131019091020.GE9312@longonot.mountain>
On Oct 19 Clemens Ladisch wrote:
> Dan Carpenter wrote:
> > There is a 4 byte hole in the bus_reset struct at the end of the struct
> > after ->generation.
>
> queue_bus_reset_event() uses kzalloc(), and ioctl_get_info() does not copy
> the hole.
Yep. In other words, the ioctl_get_info() information leak has been
fixed by commit 790198f74c9d "firewire: cdev: fix user memory corruption
(i386 userland on amd64 kernel)". Its subject doesn't say so, but the
changelog does.
--
Stefan Richter
-===-==-= =-=- =--=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2013-10-19 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 9:10 [patch] firewire: info leak in ioctl_get_info() Dan Carpenter
2013-10-19 10:24 ` Clemens Ladisch
2013-10-19 11:03 ` Stefan Richter [this message]
2013-10-19 11:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131019130346.5f8ad3a5@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.