All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Geyslan G. Bem" <geyslan@gmail.com>,
	kernel-br@googlegroups.com,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH] tracing: fix referencing after memory freeing and refactors code
Date: Sat, 19 Oct 2013 15:34:01 +0200	[thread overview]
Message-ID: <20131019133401.GA27798@redhat.com> (raw)
In-Reply-To: <20131019124312.GA23872@redhat.com>

Steven, et all, sorry for off-topic...

You probably know that kernel/trace/ is not trivial ;) and the fact
that cscope doesn't shows the callers in kernel/trace/trace_events.c
doesn't really help.

Fixed by the patch below, but I am not sure it is fine to uglify the
code to help the buggy tools. Is there any other way?

Oleg.
---

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 368a4d5..087fff1 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -68,6 +68,9 @@ static int system_refcount_dec(struct event_subsystem *system)
 		struct ftrace_event_file *___n;				\
 		list_for_each_entry_safe(file, ___n, &tr->events, list)
 
+/* Yes. Twice to not confuse csope */
+#define while_for_each_event_file()		\
+	}
 #define while_for_each_event_file()		\
 	}
 


  reply	other threads:[~2013-10-19 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-18  1:44 [PATCH] tracing: fix referencing after memory freeing and refactors code Geyslan G. Bem
2013-10-18  2:46 ` Steven Rostedt
2013-10-18  9:49   ` Geyslan Gregório Bem
2013-10-18 11:02     ` Geyslan Gregório Bem
2013-10-18 12:34       ` Steven Rostedt
2013-10-19 12:43   ` Oleg Nesterov
2013-10-19 13:34     ` Oleg Nesterov [this message]
2013-10-19 13:58     ` Geyslan Gregório Bem
2013-10-19 14:18       ` Oleg Nesterov
2013-10-19 14:41         ` Geyslan Gregório Bem
2013-10-19 19:10           ` Steven Rostedt
2013-10-19 19:35             ` Geyslan Gregório Bem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131019133401.GA27798@redhat.com \
    --to=oleg@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=geyslan@gmail.com \
    --cc=kernel-br@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.