From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: Pericom PCIe Serial board Support (12d8:7952/4/8) - Chip PI7C9X7952/4/8 Date: Sat, 19 Oct 2013 19:51:51 -0700 Message-ID: <20131020025151.GA31823@kroah.com> References: <20131015140903.GA20755@kroah.com> <20131015172801.GA27279@kroah.com> <525D9A56.9080402@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44142 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113Ab3JTHi2 (ORCPT ); Sun, 20 Oct 2013 03:38:28 -0400 Content-Disposition: inline In-Reply-To: <525D9A56.9080402@gmail.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Angelo Butti Cc: linux-serial@vger.kernel.org On Tue, Oct 15, 2013 at 10:41:10PM +0300, Angelo Butti wrote: > On 10/15/2013 08:28 PM, Greg KH wrote: > > On Tue, Oct 15, 2013 at 07:20:18PM +0200, Angelo Butti wrote: > >> I'm really sorry for my mistake. > > > > No worries, but your email client turned all tabs into spaces, and made > > the patch imposible to apply :( > > > >> Also, maybe that there is a simple way to change the clock without > >> rewrite the standard serial setup procedure, but I cannot find it .... > >> Below the correct one: > >> > >> --- linux-3.10.11-200.fc19.i686/drivers/tty/serial/8250/8250_pci.c.orig > >> 2013-09-16 20:13:52.918548000 +0300 > >> +++ linux-3.10.11-200.fc19.i686/drivers/tty/serial/8250/8250_pci.c > >> 2013-10-15 16:20:18.566685996 +0300 > >> @@ -1308,6 +1308,29 @@ static int pci_default_setup(struct seri > >> return setup_port(priv, port, bar, offset, board->reg_shift); > >> } > >> > >> +static int pci_pericom_setup(struct serial_private *priv, > >> + const struct pciserial_board *board, > >> + struct uart_8250_port *port, int idx) > > > > See? > > > > Also, we need a "Signed-off-by:" line as per the instructions in the > > Documentation/SubmittingPatches file (take a look at it for what that > > means.) > > > > Care to try again? > > > > thanks, > > > > greg k-h > > > > Ok, I change the email client .... I hope .... The patch was a bit whitespace dammaged, but I fixed it up by hand and applied it. thanks, greg k-h