From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 01/16] sandbox: Make map_to_sysmem() use a constant pointer
Date: Sun, 20 Oct 2013 07:05:46 +0200 [thread overview]
Message-ID: <201310200705.46733.marex@denx.de> (raw)
In-Reply-To: <1382135604-31828-2-git-send-email-sjg@chromium.org>
Dear Simon Glass,
> Very often a constant pointer is passed to this function, so we should
> declare this, since map_to_sysmem() does not change the pointer.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Marek Vasut <marex@denx.de>
I think this can be applied separately.
> ---
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> arch/sandbox/include/asm/io.h | 2 +-
> include/common.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sandbox/include/asm/io.h b/arch/sandbox/include/asm/io.h
> index 9ac6a5f..7956041 100644
> --- a/arch/sandbox/include/asm/io.h
> +++ b/arch/sandbox/include/asm/io.h
> @@ -38,6 +38,6 @@ static inline void unmap_sysmem(const void *vaddr)
> }
>
> /* Map from a pointer to our RAM buffer */
> -phys_addr_t map_to_sysmem(void *ptr);
> +phys_addr_t map_to_sysmem(const void *ptr);
>
> #endif
> diff --git a/include/common.h b/include/common.h
> index 409515f..8ca67f6 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -923,7 +923,7 @@ static inline void unmap_sysmem(const void *vaddr)
> {
> }
>
> -static inline phys_addr_t map_to_sysmem(void *ptr)
> +static inline phys_addr_t map_to_sysmem(const void *ptr)
> {
> return (phys_addr_t)(uintptr_t)ptr;
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-20 5:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 22:33 [U-Boot] [PATCH v4 0/16] Driver model implementation, tests, demo and GPIO Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 01/16] sandbox: Make map_to_sysmem() use a constant pointer Simon Glass
2013-10-20 5:05 ` Marek Vasut [this message]
2013-10-18 22:33 ` [U-Boot] [PATCH v4 02/16] sandbox: Correct data sizes and printf() strings in fdtdec.c Simon Glass
2013-10-20 5:06 ` Marek Vasut
2013-10-18 22:33 ` [U-Boot] [PATCH v4 03/16] sandbox: config: Don't use 64-bit physical memory Simon Glass
2013-10-20 5:08 ` Marek Vasut
2013-10-20 5:13 ` Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 04/16] sandbox: Build a device tree file for sandbox Simon Glass
2013-10-20 5:09 ` Marek Vasut
2013-10-20 5:23 ` Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 05/16] Add cmd_process_error() to report and process errors Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 06/16] sandbox: config: Enable driver model Simon Glass
2013-10-20 5:11 ` Marek Vasut
2013-10-20 19:05 ` Simon Glass
2013-10-20 19:36 ` Marek Vasut
2013-10-20 20:05 ` Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 07/16] dm: Add README for " Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 08/16] dm: Add base driver model support Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 09/16] dm: Set up driver model after relocation Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 10/16] dm: Add basic tests Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 11/16] dm: Add a 'dm' command for testing Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 12/16] dm: Add a demonstration/example driver Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 13/16] dm: Add GPIO support and tests Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 14/16] sandbox: Convert GPIOs to use driver model Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 15/16] dm: Enable gpio command to support " Simon Glass
2013-10-18 22:33 ` [U-Boot] [PATCH v4 16/16] dm: Move old driver model documentation into an 'old-docs' directory Simon Glass
2013-10-20 5:12 ` Marek Vasut
2013-10-20 19:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310200705.46733.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.