Re: [PATCH v3 4/9] ACPI, x86: Extended error log driver for x86 platform

[Chen Gong <gong.chen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]

[...]

> >diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> >index 22327e6..c67ec61 100644
> >--- a/drivers/acpi/Kconfig
> >+++ b/drivers/acpi/Kconfig
> >@@ -372,4 +372,24 @@ config ACPI_BGRT
> >
> >  source "drivers/acpi/apei/Kconfig"
> >
> >+config ACPI_EXTLOG
> >+	tristate "Extended Error Log support"
> >+	depends on X86_MCE
> 
> I think you also have a dependancy on ACPI_APEI for apei_estatus_print()
> 
Oh, yes it is. Furthermore, it reminds me where is the best place to put
cper.c from I write this patch series. CPER really doesn't dpend on APEI
even ACPI. Maybe lib/ ia an option. I can update this patch and if it is
OK, I can add another separate patch to change this dependency. Make
sense?

> >+	default n
> >+	help
> >+	  Certain usages such as Predictive Failure Analysis (PFA) require
> >+	  more information about the error than what can be described in
> >+	  processor machine check banks. Most server processors log
> >+	  additional information about the error in processor uncore
> >+	  registers. Since the addresses and layout of these registers vary
> >+	  widely from one processor to another, system software cannot
> >+	  readily make use of them. To complicate matters further, some of
> >+	  the additional error information cannot be constructed space
> >+	  between "additional" and "error" without detailed knowledge
> 
> Oops... looks like copy+paste went wrong ;)
> 
Sigh, it looks like I have m a little bit hurry. 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]