From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from top.free-electrons.com ([176.31.233.9] helo=mail.free-electrons.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VXqeA-0006lE-6r for linux-mtd@lists.infradead.org; Sun, 20 Oct 2013 10:54:11 +0000 Date: Sun, 20 Oct 2013 07:54:00 -0300 From: Ezequiel Garcia To: "Gupta, Pekon" Subject: Re: [PATCH] mtd: nand: use a local variable to simplify the nand_scan_tail Message-ID: <20131020105359.GA2465@localhost> References: <1382077253-21709-1-git-send-email-b32955@freescale.com> <20980858CB6D3A4BAE95CA194937D5E73EA2866E@DBDE04.ent.ti.com> <20131019130846.GB2470@localhost> <20980858CB6D3A4BAE95CA194937D5E73EA28EB9@DBDE04.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA28EB9@DBDE04.ent.ti.com> Cc: Huang Shijie , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , "linux-mtd@lists.infradead.org" , "dedekind1@gmail.com" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Oct 20, 2013 at 07:01:11AM +0000, Gupta, Pekon wrote: > > From: Ezequiel Garcia [mailto:ezequiel.garcia@free-electrons.com] > > > On Fri, Oct 18, 2013 at 02:11:19PM +0000, Gupta, Pekon wrote: > > > > From: Huang Shijie > > > > There are too many "chip->ecc" in the nand_scan_tail() which makes the > > > > eyes > > > > sore. > > > > > > > > This patch uses a local variable "ecc" to replace the "chip->ecc" to > > > > make the code more graceful. > > > > > > > > Do the code change with "s/chip->ecc\./ecc->/g" in the nand_scan_tail, > > > > and also change some lines by hand. > > > > > > > > Signed-off-by: Huang Shijie > > > > > > > Personally I won't prefer such stand-alone cleanup _unless_ there is > > > major driver re-write of the code, because this breaks the traceability > > > via 'git blame'. And even in that case, this change should be applied first, > > > and the other functional updates later. > > > > > > > Hm.. I'm not sure I agree here. I like this patch and I like the effect > > it has on nand_scan_tail(). > > > > On a personal note, I hardly ever use git blame at all (because it's dead > > slow). Instead, I just run git log ${file} and get the latest changes on > > that file. > > > Its rather difficult to use 'git log' especially when you are tracing or debugging > a generic driver, and want to know why this piece of code was introduced, > and the idea behind it. 'git log' won’t show line by line commit details. > Quite the opposite 'git log --patch' shows the commit details. Or maybe you need something that I'm not aware of? I really don't think we should dis-encourage cleanups -in what ever form and time they might come- just to preserve the last 'major' author of a file. But this is just my two cents... -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com