From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH] ASoC: kirkwood: cleanup the external clock probe Date: Mon, 21 Oct 2013 12:09:16 +0200 Message-ID: <20131021120916.3a3ffcf8@armhf> References: <20131021094613.2a07bd79@armhf> <20131021080657.GU25034@n2100.arm.linux.org.uk> <20131021102834.768c0887@armhf> <20131021085200.GW25034@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [212.27.42.5]) by alsa0.perex.cz (Postfix) with ESMTP id AA1F5265071 for ; Mon, 21 Oct 2013 12:09:01 +0200 (CEST) In-Reply-To: <20131021085200.GW25034@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Thomas Petazzoni , alsa-devel@alsa-project.org, Russell King - ARM Linux , Jason Cooper , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: alsa-devel@alsa-project.org T24gTW9uLCAyMSBPY3QgMjAxMyAwOTo1MjowMCArMDEwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiA+ID4gTkFLLiAgSXQgY2FuIG9j Y3VyLiAgCj4gPiAKPiA+IEluIHdoaWNoIGNhc2U/IEFuZCwgd2hhdCB3b3VsZCBiZSB0aGUgcmln aHQgdHJlYXRtZW50PyAgCj4gCj4gICAgICAgICBwcml2LT5jbGsgPSBkZXZtX2Nsa19nZXQoJnBk ZXYtPmRldiwgTlVMTCk7Cj4gICAgICAgICBwcml2LT5leHRjbGsgPSBkZXZtX2Nsa19nZXQoJnBk ZXYtPmRldiwgImV4dGNsayIpOwo+IAo+IFN1cHBseWluZyB0aGUgZmlyc3QgY2xvY2sgdG8gdGhp cyBkcml2ZXIgd2l0aG91dCBhIHNlcGFyYXRlICJleHRjbGsiCj4gdmlhIGNsa2RldiB3aWxsIHJl dHVybiBpdCBhcyB0aGUgc2Vjb25kIGNsb2NrLgo+IAo+IEFnYWluLCBOQUsuICBZb3VyIGNoYW5n ZSBpcyBhZ2FpbnN0IHRoZSBwcmluY2lwbGVzIG9mIHRoZSBjbGsgQVBJLgoKWW91IGFyZSByaWdo dC4KCk1hcmssIHBsZWFzZSBmb3JnZXQgYWJvdXQgdGhpcyBwYXRjaC4KClRoYW5rcy4KCi0tIApL ZW4gYXIgYydoZW50YcOxCXwJICAgICAgKiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJ fAkJaHR0cDovL21vaW5lamYuZnJlZS5mci8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNh LXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Mon, 21 Oct 2013 12:09:16 +0200 Subject: [PATCH] ASoC: kirkwood: cleanup the external clock probe In-Reply-To: <20131021085200.GW25034@n2100.arm.linux.org.uk> References: <20131021094613.2a07bd79@armhf> <20131021080657.GU25034@n2100.arm.linux.org.uk> <20131021102834.768c0887@armhf> <20131021085200.GW25034@n2100.arm.linux.org.uk> Message-ID: <20131021120916.3a3ffcf8@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 21 Oct 2013 09:52:00 +0100 Russell King - ARM Linux wrote: > > > NAK. It can occur. > > > > In which case? And, what would be the right treatment? > > priv->clk = devm_clk_get(&pdev->dev, NULL); > priv->extclk = devm_clk_get(&pdev->dev, "extclk"); > > Supplying the first clock to this driver without a separate "extclk" > via clkdev will return it as the second clock. > > Again, NAK. Your change is against the principles of the clk API. You are right. Mark, please forget about this patch. Thanks. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/