From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Clamp cursor coordinates to int16_t range
Date: Mon, 21 Oct 2013 19:24:39 +0300 [thread overview]
Message-ID: <20131021162439.GA13047@intel.com> (raw)
In-Reply-To: <CAKMK7uGcSu_d1EDTuPMMQeAhCcRVhv7DeQCBQepf-OR5V031mQ@mail.gmail.com>
On Mon, Oct 21, 2013 at 06:15:06PM +0200, Daniel Vetter wrote:
> On Mon, Oct 21, 2013 at 6:01 PM, <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We store cursor_x/y as int16_t internally, but the user provided
> > coordinates are int32_t. Clamp the coordinates so that they don't
> > overflow the int16_t. Since the cursor is only 64x64 in size, the
> > clamping can't cause any visual changes.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>
> For shits&giggles: You've bothered with a subtest for this in your crc
> cursor test? Should be a one-liner and would neatly test whether QA
> catches it ...
Yeah it's there. Actually I added the test before I knew the bug
existed. The test is what found the bug for me.
It's not a specific subtest though, but part of all the bigger
cursor-offscreen subtests. The subtest split I'm using there isn't
very fine grained. Maybe I should change that actually. It would
help in pinpointing the failing cases more accurately.
--
Ville Syrjälä
Intel OTC
prev parent reply other threads:[~2013-10-21 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 16:01 [PATCH] drm/i915: Clamp cursor coordinates to int16_t range ville.syrjala
2013-10-21 16:13 ` Chris Wilson
2013-10-28 17:01 ` Daniel Vetter
2013-10-21 16:15 ` Daniel Vetter
2013-10-21 16:24 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131021162439.GA13047@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.