All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Jim Davis <jim.epost@gmail.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	jic23@kernel.org, gregkh@linuxfoundation.org,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH -next] staging/iio/adc: MXS_LRADC depends on INPUT
Date: Tue, 22 Oct 2013 06:51:03 +0200	[thread overview]
Message-ID: <201310220651.03499.marex@denx.de> (raw)
In-Reply-To: <526603EB.3060504@infradead.org>

Dear Randy Dunlap,

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> mxs-lradc.c uses many input_() functions so it should
> depend on INPUT to fix build errors.
> 
> drivers/built-in.o: In function `mxs_lradc_ts_unregister':
> drivers/staging/iio/adc/mxs-lradc.c:905: undefined reference to
> `input_unregister_device' drivers/staging/iio/adc/mxs-lradc.c:905:
> undefined reference to `input_unregister_device' drivers/built-in.o: In
> function `input_report_abs':
> include/linux/input.h:399: undefined reference to `input_event'
> include/linux/input.h:399: undefined reference to `input_event'
> include/linux/input.h:399: undefined reference to `input_event'
> drivers/built-in.o: In function `input_report_key':
> include/linux/input.h:389: undefined reference to `input_event'
> drivers/built-in.o: In function `input_sync':
> include/linux/input.h:414: undefined reference to `input_event'
> drivers/built-in.o:include/linux/input.h:389: more undefined references to
> `input_event' follow
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Acked-by: Marek Vasut <marex@denx.de>

Thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2013-10-22  4:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 19:07 randconfig build error with next-20131021, in drivers/staging/iio/adc Jim Davis
2013-10-21 19:07 ` Jim Davis
2013-10-22  4:49 ` [PATCH -next] staging/iio/adc: MXS_LRADC depends on INPUT Randy Dunlap
2013-10-22  4:49   ` Randy Dunlap
2013-10-22  4:51   ` Marek Vasut [this message]
2013-10-23 15:55     ` Jonathan Cameron
2013-10-23 15:55       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310220651.03499.marex@denx.de \
    --to=marex@denx.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=jim.epost@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.