Re: [PATCH v2] pwm_backlight: avoid short blank screen while doing hibernation

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On Wed, Oct 09, 2013 at 10:33:02AM +0800, Barry Song wrote:
> From: Huayi Li <huayi.li@csr.com>
> 
> Use SIMPLE_DEV_PM_OPS macro will initialize the member "freeze"
> and "thaw" of pwm_backlight_pm_ops as below,
> 	.freeze = suspend_fn,
> 	.thaw = resume_fn,
> then during the process of making hibernation snapshot, screen
> will be blank at the moment of freezing, and then light at the
> moment of thawing.
> this is not the right user experience for suspending to disk.
> 
> so this patch drops freeze and thaw callback, make the LCD is
> always lighting before the final shutdown.
> 
> Signed-off-by: Huayi Li <huayi.li@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---
>  -v2: move the #ifdef inside of the pwm_backlight_pwm_ops so that we
>  don't have to clutter the platform_driver here
> 
>  drivers/video/backlight/pwm_bl.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]