From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Move the pipe CRC stuff to other
 pipe data
Date: Tue, 22 Oct 2013 11:15:40 +0300
Message-ID: <20131022081540.GD13047@intel.com>
References: <1382382620-23405-1-git-send-email-daniel.vetter@ffwll.ch>
	<20131021204759.GB19663@strange.amr.corp.intel.com>
	<CAKMK7uEVAPc5tTAWh5xtzqT+rhXU_+TR6SAu=WswAh90ehGSvA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 10142E61D5
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 22 Oct 2013 01:15:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAKMK7uEVAPc5tTAWh5xtzqT+rhXU_+TR6SAu=WswAh90ehGSvA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Oct 21, 2013 at 10:54:16PM +0200, Daniel Vetter wrote:
> On Mon, Oct 21, 2013 at 10:47 PM, Damien Lespiau
> <damien.lespiau@intel.com> wrote:
> > On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote:
> >> Adding stuff to the bottom of struct drm_i915_driver_private is
> >> nowadays considered uncool.
> >>
> >> Cc: Damien Lespiau <damien.lespiau@intel.com>
> >> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Ville was suggesting moving the pipe_crc struct into intel_crtc. Might
> > be even better! But anyway:
> =

> We enable interrupts before we allocate the intel_crtc structs. So if
> we'd store the CRC stuff in there we'd need to be a bit more paranoid
> with clearing hw state (since every time we trust the BIOS we end up
> burning our hands). So I think this is safer ...

FLIP_DONE etc. interrupts already depend on the crtc being there. Not
sure why this is different.

-- =

Ville Syrj=E4l=E4
Intel OTC