From: Stanislav Fomichev <stfomichev@yandex-team.ru>
To: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
acme@ghostprotocols.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf timechart: remove lock_depth from trace_entry
Date: Tue, 22 Oct 2013 14:32:23 +0400 [thread overview]
Message-ID: <20131022103223.GA29489@stfomichev-desktop> (raw)
In-Reply-To: <1381128514-16279-1-git-send-email-olvaffe@gmail.com>
On Mon, Oct 07, 2013 at 02:48:34PM +0800, Chia-I Wu wrote:
> struct trace_entry went out-of-sync with the kernel since
>
> commit b000c8065 "tracing: Remove the extra 4 bytes of padding in events"
>
> causing "perf timechart" to be broken.
>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Stanislav Fomichev <stfomichev@yandex-team.ru>
For some reason nobody noticed this patch on lkml, so resending to the
maintainers...
This also makes sense to merge it into the stable line.
> ---
> tools/perf/builtin-timechart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
> index c2e0231..f9cbc18 100644
> --- a/tools/perf/builtin-timechart.c
> +++ b/tools/perf/builtin-timechart.c
> @@ -303,7 +303,6 @@ struct trace_entry {
> unsigned char flags;
> unsigned char preempt_count;
> int pid;
> - int lock_depth;
> };
>
> #ifdef SUPPORT_OLD_POWER_EVENTS
> --
> 1.8.3.1
next prev parent reply other threads:[~2013-10-22 10:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 6:48 [PATCH] perf timechart: remove lock_depth from trace_entry Chia-I Wu
2013-10-22 10:32 ` Stanislav Fomichev [this message]
2013-11-25 18:21 ` Arnaldo Carvalho de Melo
2013-11-26 11:05 ` Stanislav Fomichev
2013-11-26 12:10 ` Arnaldo Carvalho de Melo
2013-11-26 13:47 ` Stanislav Fomichev
2013-11-26 13:57 ` Arnaldo Carvalho de Melo
2013-11-26 14:54 ` [PATCH] perf timechart: dynamically determine event data offset Stanislav Fomichev
2013-11-26 22:04 ` Arnaldo Carvalho de Melo
2013-11-27 8:49 ` Namhyung Kim
2013-11-27 9:01 ` Stanislav Fomichev
2013-11-27 10:45 ` [PATCH] perf timechart: dynamically determine event fields offset Stanislav Fomichev
2013-11-30 12:53 ` [tip:perf/core] " tip-bot for Stanislav Fomichev
2013-11-27 13:44 ` [PATCH] perf timechart: dynamically determine event data offset Arnaldo Carvalho de Melo
2013-11-27 14:17 ` Namhyung Kim
2013-11-27 14:41 ` Arnaldo Carvalho de Melo
2013-11-27 14:51 ` Namhyung Kim
2013-11-27 14:55 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022103223.GA29489@stfomichev-desktop \
--to=stfomichev@yandex-team.ru \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.