From: Sylvain BERTRAND <sylware@legeek.net>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: endianness of rlc buffers (SI)
Date: Tue, 22 Oct 2013 13:43:00 +0200 [thread overview]
Message-ID: <20131022114300.GA206@freedom> (raw)
In-Reply-To: <CADnq5_M1gN4XtmBXXzbEhAwwFhQGMQmYV2LLTE_m50Jk9Ka5Gw@mail.gmail.com>
>> commit 555b1b651acf44bf27ebbb04235d38a8fd2d58dc (drm-fixes-3.12)
>>
>> evergreen.c, SI code path, line 4045 and 4046 shouldn't be swapped?
>> Should cpu_to_le32 be used?
>>
>> Basically, is the endianness enforcement right for the rlc BOs?
>> Or is there a bit somewhere to switch the RLC to host
>> endianness? Or the kmap is swapping dwords?
>
> The rlc buffers should be little endian. They will need to be swapped
> on big endian systems.
Right, then cpu_to_le32 should be used.
Still for endianness, upper dword is written first (line 4045) and
lower dword is written second (line 4046): Should the lower dword be
written first then second the upper dword if we want little endian?
Or maybe in that specific case, the rlc expect the upper dword first?
--
Sylvain
next prev parent reply other threads:[~2013-10-22 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 0:26 endianness of rlc buffers (SI) Sylvain BERTRAND
2013-10-22 5:13 ` Alex Deucher
2013-10-22 11:43 ` Sylvain BERTRAND [this message]
2013-10-22 22:59 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131022114300.GA206@freedom \
--to=sylware@legeek.net \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.