All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Qinglai Xiao <jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] ixgbe: query assignment of queues to VF
Date: Wed, 23 Oct 2013 11:19:04 +0200	[thread overview]
Message-ID: <201310231119.04536.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1382364674-27098-1-git-send-email-jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

21/10/2013 16:11, Qinglai Xiao :
> Physical Function assignes Tx/Rx queues to each VF according to
> different schemes[1]. By querying through mailbox, VF is able to
> get number of Tx/Rx queues assigned to it.
> 
> Note that current Intel ixgbe driver ixgbe-3.18.7 does not fully
> support mailbox message IXGBE_VF_GET_QUEUES. The service routine
> for IXGBE_VF_GET_QUEUES must be fixed, otherwise PF always return
> 1 as Tx/Rx queue number.
> 
> [1] See section 7.2.1.2.1, 7.1.2.2 and 7.10.2.7.2 of Intel 82599 10
>     Gbe Controller Datasheet.
> 
> Signed-off-by: Qinglai Xiao <jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked and applied with light modifications:

-	 * Must let PF know we are at mailbox API 11 level.
+	 * Must let PF know we are at mailbox API version 1.1.

> +}
> +
> +
>  /*
>   * Virtual Function device init

Only 1 empty line is sufficient here.

Thanks for your patch.
Please, keep us informed about the needed PF patch.
-- 
Thomas

  parent reply	other threads:[~2013-10-23  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 14:11 [PATCH] ixgbe 82599: Query assignment of queues to Virtual Function Qinglai Xiao
     [not found] ` <1382364674-27098-1-git-send-email-jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-10-23  9:19   ` Thomas Monjalon [this message]
     [not found]     ` <201310231119.04536.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-10-23 12:26       ` [PATCH] ixgbe: query assignment of queues to VF jigsaw
     [not found]         ` <CAHVfvh5DmT7jdUuze9L4Dqg6bBtRkE0aKKw_frXwnkGKT03jkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-24  8:48           ` Thomas Monjalon
     [not found]             ` <201310241048.26413.thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2013-10-24  9:38               ` jigsaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201310231119.04536.thomas.monjalon@6wind.com \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=jigsaw-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.