From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V2 12/14] perf sched: Fix optimized build time
Date: Wed, 23 Oct 2013 10:17:50 -0300 [thread overview]
Message-ID: <20131023131750.GB14490@ghostprotocols.net> (raw)
In-Reply-To: <1382427258-17495-13-git-send-email-adrian.hunter@intel.com>
Em Tue, Oct 22, 2013 at 10:34:16AM +0300, Adrian Hunter escreveu:
> builtin-sched.c took a log time to build with
> -O6 optimization. This turned out to be caused
> by:
>
> .curr_pid = { [0 ... MAX_CPUS - 1] = -1 },
>
> Fix by initializing curr_pid programmatically.
Ok, understood, so its just this bit that was causing the delay,
applying both patches, thanks!
- Arnaldo
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/builtin-sched.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index 5a33856..ddb5dc1 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1670,7 +1670,6 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
> .sort_list = LIST_HEAD_INIT(sched.sort_list),
> .start_work_mutex = PTHREAD_MUTEX_INITIALIZER,
> .work_done_wait_mutex = PTHREAD_MUTEX_INITIALIZER,
> - .curr_pid = { [0 ... MAX_CPUS - 1] = -1 },
> .sort_order = default_sort_order,
> .replay_repeat = 10,
> .profile_cpu = -1,
> @@ -1732,6 +1731,10 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
> .switch_event = replay_switch_event,
> .fork_event = replay_fork_event,
> };
> + unsigned int i;
> +
> + for (i = 0; i < ARRAY_SIZE(sched.curr_pid); i++)
> + sched.curr_pid[i] = -1;
>
> argc = parse_options(argc, argv, sched_options, sched_usage,
> PARSE_OPT_STOP_AT_NON_OPTION);
> --
> 1.7.11.7
next prev parent reply other threads:[~2013-10-23 13:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 7:34 [PATCH V2 00/14] perf tools: fixes and tweaks Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 01/14] perf tools: Fix non-debug build Adrian Hunter
2013-10-25 10:32 ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 02/14] perf evsel: Add a debug print if perf_event_open fails Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 03/14] perf script: Make perf_script a local variable Adrian Hunter
2013-10-23 5:55 ` David Ahern
2013-10-25 10:32 ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 04/14] perf script: Set up output options for in-stream attributes Adrian Hunter
2013-10-23 6:15 ` David Ahern
2013-10-23 6:41 ` Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 05/14] perf inject: Do not repipe attributes to a perf.data file Adrian Hunter
2013-10-25 10:32 ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 06/14] perf tools: Fix 32-bit cross build Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 07/14] perf tools: Fix libunwind build and feature detection for 32-bit build Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 08/14] perf evlist: Add a debug print if event buffer mmap fails Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 09/14] perf record: Add an option to force per-cpu mmaps Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 10/14] perf tools: Allow non-matching sample types Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 11/14] perf sched: Make struct perf_sched sched a local variable Adrian Hunter
2013-10-23 6:43 ` David Ahern
2013-10-23 13:16 ` Arnaldo Carvalho de Melo
2013-10-25 10:32 ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 12/14] perf sched: Fix optimized build time Adrian Hunter
2013-10-23 6:44 ` David Ahern
2013-10-23 13:17 ` Arnaldo Carvalho de Melo [this message]
2013-10-25 10:32 ` [tip:perf/core] perf sched: Optimize " tip-bot for Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 13/14] perf tools: Do not accept parse_tag_value() overflow Adrian Hunter
2013-10-25 10:32 ` [tip:perf/core] " tip-bot for Adrian Hunter
2013-10-22 7:34 ` [PATCH V2 14/14] perf tools: Validate that mmap_pages is not too big Adrian Hunter
2013-10-25 10:32 ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023131750.GB14490@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.